From: Varka Bhadram <varkabhadram@gmail.com>
To: Andy Zhou <azhou@nicira.com>, davem@davemloft.net
Cc: netdev@vger.kernel.org
Subject: Re: [net-next 01/10] net: Rename ndo_add_vxlan_port to ndo_add_udp_tunnel_port.
Date: Tue, 22 Jul 2014 16:19:25 +0530 [thread overview]
Message-ID: <53CE41B5.5070608@gmail.com> (raw)
In-Reply-To: <1406024393-6778-2-git-send-email-azhou@nicira.com>
On 07/22/2014 03:49 PM, Andy Zhou wrote:
(...)
>
> -/* Calls the ndo_add_vxlan_port of the caller in order to
> +/* Calls the ndo_add_tunnel_port of the caller in order to
> * supply the listening VXLAN udp ports. Callers are expected
> - * to implement the ndo_add_vxlan_port.
> + * to implement the ndo_add_tunnle_port.
> */
> void vxlan_get_rx_port(struct net_device *dev)
> {
> @@ -2206,8 +2209,8 @@ void vxlan_get_rx_port(struct net_device *dev)
> hlist_for_each_entry_rcu(vs, &vn->sock_list[i], hlist) {
> port = inet_sk(vs->sock->sk)->inet_sport;
> sa_family = vs->sock->sk->sk_family;
> - dev->netdev_ops->ndo_add_vxlan_port(dev, sa_family,
> - port);
> + dev->netdev_ops->ndo_add_udp_tunnel_port(dev,
> + sa_family, port, UDP_TUNNEL_TYPE_VXLAN);
Should match open parenthesis:
dev->netdev_ops->ndo_add_udp_tunnel_port(dev,
sa_family, port,
UDP_TUNNEL_TYPE_VXLAN);
>
--
Regards,
Varka Bhadram.
next prev parent reply other threads:[~2014-07-22 10:50 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 10:19 [net-next 00/10] Add Geneve Andy Zhou
2014-07-22 10:19 ` [net-next 01/10] net: Rename ndo_add_vxlan_port to ndo_add_udp_tunnel_port Andy Zhou
2014-07-22 10:49 ` Varka Bhadram [this message]
2014-07-24 6:40 ` Or Gerlitz
2014-07-24 20:28 ` Andy Zhou
2014-07-22 10:19 ` [net-next 02/10] udp: Expand UDP tunnel common APIs Andy Zhou
[not found] ` <CA+mtBx9M_BpjT-_Egng+jFxmqJzdC2Npg0ufE2ZSAb9Lhw8hxg@mail.gmail.com>
2014-07-22 21:02 ` Andy Zhou
2014-07-22 21:16 ` Tom Herbert
2014-07-22 21:56 ` Jesse Gross
2014-07-22 22:38 ` Tom Herbert
2014-07-22 22:55 ` Alexander Duyck
2014-07-22 23:24 ` Tom Herbert
2014-07-23 2:16 ` Alexander Duyck
2014-07-23 3:53 ` Tom Herbert
2014-07-23 4:35 ` Jesse Gross
2014-07-23 15:45 ` Tom Herbert
2014-07-24 3:24 ` Jesse Gross
2014-07-22 23:12 ` Jesse Gross
2014-07-23 19:57 ` Tom Herbert
2014-07-24 20:23 ` Andy Zhou
2014-07-24 20:47 ` Tom Herbert
2014-07-24 20:54 ` Andy Zhou
2014-07-22 10:19 ` [net-next 03/10] vxlan: Remove vxlan_get_rx_port() Andy Zhou
[not found] ` <CAKgT0UeRSc3MaZrLmXyx4jPZO+F1hS5imR1TjFkvKp4S8nQmeg@mail.gmail.com>
2014-07-23 3:57 ` Andy Zhou
2014-07-22 10:19 ` [net-next 04/10] net: Refactor vxlan driver to make use of common UDP tunnel functions Andy Zhou
2014-07-24 6:46 ` Or Gerlitz
2014-07-22 10:19 ` [net-next 05/10] net: Add Geneve tunneling protocol driver Andy Zhou
2014-07-22 23:12 ` Alexander Duyck
2014-07-22 23:24 ` Jesse Gross
2014-07-23 14:11 ` John W. Linville
2014-07-23 18:20 ` Stephen Hemminger
2014-07-22 10:19 ` [net-next 06/10] openvswitch: Eliminate memset() from flow_extract Andy Zhou
2014-07-22 10:19 ` [net-next 07/10] openvswitch: Add support for matching on OAM packets Andy Zhou
2014-07-22 10:19 ` [net-next 08/10] openvswitch: Wrap struct ovs_key_ipv4_tunnel in a new structure Andy Zhou
2014-07-22 10:19 ` [net-next 09/10] openvswitch: Factor out allocation and verification of actions Andy Zhou
2014-07-22 10:19 ` [net-next 10/10] openvswitch: Add support for Geneve tunneling Andy Zhou
2014-07-23 20:29 ` Tom Herbert
2014-07-24 4:10 ` Jesse Gross
[not found] ` <CA+mtBx9umxiFYtnG1kzFkK+Ev=b=4f3q2OOow2QcfCB5rUTUyA@mail.gmail.com>
2014-07-24 22:59 ` Jesse Gross
2014-07-24 23:45 ` Tom Herbert
2014-07-25 1:04 ` Jesse Gross
2014-07-22 10:54 ` [net-next 00/10] Add Geneve Varka Bhadram
2014-07-24 6:58 ` Or Gerlitz
2014-07-24 17:40 ` Tom Herbert
2014-07-24 21:03 ` Andy Zhou
2014-07-24 22:03 ` Tom Herbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CE41B5.5070608@gmail.com \
--to=varkabhadram@gmail.com \
--cc=azhou@nicira.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).