From: Vlad Yasevich <vyasevich@gmail.com>
To: Daniel Borkmann <dborkman@redhat.com>
Cc: davem@davemloft.net, jgunthorpe@obsidianresearch.com,
netdev@vger.kernel.org, linux-sctp@vger.kernel.org
Subject: Re: [PATCH net] net: sctp: inherit auth_capable on INIT collisions
Date: Tue, 22 Jul 2014 12:41:12 -0400 [thread overview]
Message-ID: <53CE9428.9060809@gmail.com> (raw)
In-Reply-To: <53CE6632.1060707@redhat.com>
On 07/22/2014 09:25 AM, Daniel Borkmann wrote:
> Hi Vlad,
>
> On 07/18/2014 11:59 PM, Vlad Yasevich wrote:
> ...
>> So I think I know why case D ends up not authenticating the COOKIE-ACK.
>> Most likely the reason is the following statement:
>> repl = sctp_make_cookie_ack(new_asoc, chunk);
>>
>> Note that we use new_asoc, instead of current asoc.
>
> Are you sending out a patch for this?
I didn't plan on it since you said there are further issues. I thought you
were still looking.
-vlad
>
> Thanks,
>
> Daniel
next prev parent reply other threads:[~2014-07-22 16:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 18:05 [PATCH net] net: sctp: inherit auth_capable on INIT collisions Daniel Borkmann
2014-07-18 12:35 ` Neil Horman
2014-07-18 14:38 ` Vlad Yasevich
2014-07-18 19:17 ` Daniel Borkmann
2014-07-18 21:59 ` Vlad Yasevich
2014-07-18 22:13 ` Daniel Borkmann
2014-07-18 23:03 ` Daniel Borkmann
2014-07-19 2:23 ` Vlad Yasevich
2014-07-20 9:13 ` Daniel Borkmann
2014-07-18 23:23 ` Daniel Borkmann
2014-07-22 13:25 ` Daniel Borkmann
2014-07-22 16:41 ` Vlad Yasevich [this message]
2014-07-22 16:43 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CE9428.9060809@gmail.com \
--to=vyasevich@gmail.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).