From: Daniel Borkmann <dborkman@redhat.com>
To: Varka Bhadram <varkabhadram@gmail.com>
Cc: Alexei Starovoitov <ast@plumgrid.com>,
"David S. Miller" <davem@davemloft.net>,
Ingo Molnar <mingo@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] net: filter: split filter.c into two files
Date: Wed, 23 Jul 2014 10:54:04 +0200 [thread overview]
Message-ID: <53CF782C.2040401@redhat.com> (raw)
In-Reply-To: <53CF522E.9090408@gmail.com>
On 07/23/2014 08:11 AM, Varka Bhadram wrote:
> On 07/23/2014 11:31 AM, Alexei Starovoitov wrote:
>> BPF is used in several kernel components. This split creates logical boundary
>> between generic eBPF core and the rest
>>
>> kernel/bpf/core.c: eBPF interpreter
>>
>> net/core/filter.c: classic->eBPF converter, classic verifiers, socket filters
>>
>> This patch only moves functions.
>
> If we are moving the code also its good to do cleanup.
>
> Run checkpatch.pl on this...
Not sure what you understand as a cleanup, but there's nothing
wrong with it and most things reported are either intentional or
false positives as you might have seen already. The only thing
one could do later on perhaps is to rename related functions to
have consistently a 'bpf' prefix instead of 'sk' since they
won't be under net/ anymore.
next prev parent reply other threads:[~2014-07-23 8:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 6:01 [PATCH net-next 0/2] net: filter: split eBPF interpreter out of core networking Alexei Starovoitov
2014-07-23 6:01 ` [PATCH net-next 1/2] net: filter: split filter.c into two files Alexei Starovoitov
2014-07-23 6:11 ` Varka Bhadram
2014-07-23 8:26 ` David Laight
2014-07-23 8:54 ` Daniel Borkmann [this message]
2014-07-23 16:49 ` Alexei Starovoitov
2014-07-24 23:45 ` Valdis.Kletnieks
2014-07-24 23:58 ` Alexei Starovoitov
2014-07-25 0:48 ` Valdis.Kletnieks
2014-07-23 6:01 ` [PATCH net-next 2/2] bpf: update MAINTAINERS entry Alexei Starovoitov
2014-07-24 4:08 ` [PATCH net-next 0/2] net: filter: split eBPF interpreter out of core networking David Miller
-- strict thread matches above, loose matches on Subject: below --
2014-06-01 1:42 [PATCH net-next 0/2] split BPF " Alexei Starovoitov
2014-06-01 1:42 ` [PATCH net-next 1/2] net: filter: split filter.c into two files Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CF782C.2040401@redhat.com \
--to=dborkman@redhat.com \
--cc=ast@plumgrid.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=varkabhadram@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).