From: Tom Lendacky <thomas.lendacky@amd.com>
To: <weiyj_lk@163.com>, Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>
Cc: Wei Yongjun <yongjun_wei@trendmicro.com.cn>, <netdev@vger.kernel.org>
Subject: Re: [PATCH] amd-xgbe: Fix error return code in xgbe_probe()
Date: Wed, 23 Jul 2014 08:25:55 -0500 [thread overview]
Message-ID: <53CFB7E3.8060608@amd.com> (raw)
In-Reply-To: <1406077180-28852-1-git-send-email-weiyj_lk@163.com>
On 07/22/2014 07:59 PM, weiyj_lk@163.com wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix to return a negative error code from the setting real tx queue
> count error handling case instead of 0.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
> drivers/net/ethernet/amd/xgbe/xgbe-main.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-main.c b/drivers/net/ethernet/amd/xgbe/xgbe-main.c
> index c83584a..5a1891f 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe-main.c
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-main.c
> @@ -339,7 +339,8 @@ static int xgbe_probe(struct platform_device *pdev)
> /* Calculate the number of Tx and Rx rings to be created */
> pdata->tx_ring_count = min_t(unsigned int, num_online_cpus(),
> pdata->hw_feat.tx_ch_cnt);
> - if (netif_set_real_num_tx_queues(netdev, pdata->tx_ring_count)) {
> + ret = netif_set_real_num_tx_queues(netdev, pdata->tx_ring_count);
> + if (ret) {
> dev_err(dev, "error setting real tx queue count\n");
> goto err_io;
> }
>
next prev parent reply other threads:[~2014-07-23 13:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 0:59 [PATCH] amd-xgbe: Fix error return code in xgbe_probe() weiyj_lk
2014-07-23 13:25 ` Tom Lendacky [this message]
2014-07-23 21:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CFB7E3.8060608@amd.com \
--to=thomas.lendacky@amd.com \
--cc=grant.likely@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=weiyj_lk@163.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).