From: Sasha Levin <sasha.levin@oracle.com>
To: Andrey Ryabinin <a.ryabinin@samsung.com>,
"David S. Miller" <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Dave Jones <davej@redhat.com>,
Hannes Frederic Sowa <hannes@stressinduktion.org>,
Eric Dumazet <edumazet@google.com>
Subject: Re: net: socket: NULL ptr deref in sendmsg
Date: Fri, 25 Jul 2014 16:52:26 -0400 [thread overview]
Message-ID: <53D2C38A.70601@oracle.com> (raw)
In-Reply-To: <53D2768E.2040902@samsung.com>
On 07/25/2014 11:23 AM, Andrey Ryabinin wrote:
> After this report there was no usual "Unable to handle kernel NULL pointer dereference"
> and this gave me a clue that address 0 is mapped and contains valid socket address structure in it.
Interesting. Does it mean that all network protocols that check it for being NULL instead of checking
the length are incorrect?
(such as:)
if (msg->msg_name) {
DECLARE_SOCKADDR(struct sockaddr_can *, addr, msg->msg_name);
[...]
Thanks,
Sasha
next prev parent reply other threads:[~2014-07-25 20:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-13 21:50 net: socket: NULL ptr deref in sendmsg Sasha Levin
2014-07-14 22:08 ` David Miller
2014-07-24 16:05 ` Sasha Levin
2014-07-25 15:23 ` Andrey Ryabinin
2014-07-25 18:27 ` Eric Dumazet
2014-07-25 20:52 ` Sasha Levin [this message]
2014-07-25 22:15 ` Hannes Frederic Sowa
2014-07-26 15:40 ` Andrey Ryabinin
2014-07-25 22:15 ` Hannes Frederic Sowa
2014-07-26 15:48 ` Andrey Ryabinin
2014-07-26 15:54 ` Hannes Frederic Sowa
2014-07-26 17:26 ` [PATCH] net: sendmsg: fix NULL pointer dereference Andrey Ryabinin
2014-07-28 9:50 ` Hannes Frederic Sowa
2014-07-29 19:21 ` David Miller
2014-07-29 0:19 ` net: socket: NULL ptr deref in sendmsg David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D2C38A.70601@oracle.com \
--to=sasha.levin@oracle.com \
--cc=a.ryabinin@samsung.com \
--cc=davej@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hannes@stressinduktion.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).