From: Nikolay Aleksandrov <nikolay@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, fw@strlen.de, kuznet@ms2.inr.ac.ru,
jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net,
alex.aring@gmail.com, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next 2/4] inet: frags: rename last_in to flags, enum the definitions and add comments
Date: Fri, 01 Aug 2014 10:27:42 +0200 [thread overview]
Message-ID: <53DB4F7E.2070001@redhat.com> (raw)
In-Reply-To: <20140731.221349.304058285592989214.davem@davemloft.net>
On 08/01/2014 07:13 AM, David Miller wrote:
> From: Nikolay Aleksandrov <nikolay@redhat.com>
> Date: Thu, 31 Jul 2014 17:11:37 +0200
>
>> The last_in field has been used to store various flags different from
>> first/last frag in so give it a more descriptive name: flags. Move
>> the flags to an enum definion, swap FIRST_IN/LAST_IN to be in logical
>> order and add comments explaining each flag, also add comments explaining
>> the inet_frag_queue struct members. While at it align some function
>> declarations.
>
> When I hear things like "also" and "while at it", what I really hear is
> "that should be done in a separate patch".
>
> Please don't clump so many unrelated changes together, it makes the
> patch harder to review than necessary, thanks.
>
Sorry about that, but I thought aligning 2-3 function declarations in
inet_fragment.c was not worth a separate patch.
Anyway I'll break the aligning out.
Thanks,
Nik
next prev parent reply other threads:[~2014-08-01 8:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-31 15:11 [PATCH net-next 0/4] inet: frags: cleanup and kmem_cache use Nikolay Aleksandrov
2014-07-31 15:11 ` [PATCH net-next 1/4] inet: frags: use INC_STATS_BH in the ipv6 reassembly code Nikolay Aleksandrov
2014-07-31 21:43 ` Hannes Frederic Sowa
2014-07-31 15:11 ` [PATCH net-next 2/4] inet: frags: rename last_in to flags, enum the definitions and add comments Nikolay Aleksandrov
2014-07-31 21:26 ` Florian Westphal
2014-08-01 5:13 ` David Miller
2014-08-01 8:27 ` Nikolay Aleksandrov [this message]
2014-07-31 15:11 ` [PATCH net-next 3/4] inet: frags: use INET_FRAG_EVICTED to prevent icmp messages Nikolay Aleksandrov
2014-07-31 21:23 ` Florian Westphal
2014-07-31 15:11 ` [PATCH net-next 4/4] inet: frags: use kmem_cache for inet_frag_queue Nikolay Aleksandrov
2014-07-31 21:29 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53DB4F7E.2070001@redhat.com \
--to=nikolay@redhat.com \
--cc=alex.aring@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).