From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikolay Aleksandrov Subject: Re: [PATCH net-next 2/4] inet: frags: rename last_in to flags, enum the definitions and add comments Date: Fri, 01 Aug 2014 10:27:42 +0200 Message-ID: <53DB4F7E.2070001@redhat.com> References: <1406819499-11198-1-git-send-email-nikolay@redhat.com> <1406819499-11198-3-git-send-email-nikolay@redhat.com> <20140731.221349.304058285592989214.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, fw@strlen.de, kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, alex.aring@gmail.com, eric.dumazet@gmail.com To: David Miller Return-path: Received: from mx1.redhat.com ([209.132.183.28]:26596 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754578AbaHAI2c (ORCPT ); Fri, 1 Aug 2014 04:28:32 -0400 In-Reply-To: <20140731.221349.304058285592989214.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On 08/01/2014 07:13 AM, David Miller wrote: > From: Nikolay Aleksandrov > Date: Thu, 31 Jul 2014 17:11:37 +0200 > >> The last_in field has been used to store various flags different from >> first/last frag in so give it a more descriptive name: flags. Move >> the flags to an enum definion, swap FIRST_IN/LAST_IN to be in logical >> order and add comments explaining each flag, also add comments explaining >> the inet_frag_queue struct members. While at it align some function >> declarations. > > When I hear things like "also" and "while at it", what I really hear is > "that should be done in a separate patch". > > Please don't clump so many unrelated changes together, it makes the > patch harder to review than necessary, thanks. > Sorry about that, but I thought aligning 2-3 function declarations in inet_fragment.c was not worth a separate patch. Anyway I'll break the aligning out. Thanks, Nik