From: jflf-kernel@gmx.com
To: nic_swsd@realtek.com
Cc: netdev@vger.kernel.org
Subject: [PATCH] r8152: add missing Makefile rule
Date: Sat, 02 Aug 2014 01:26:40 +0200 [thread overview]
Message-ID: <53DC2230.9010504@gmx.com> (raw)
From: JF Le Fillatre <jflf-kernel@gmx.com>
Add missing Makefile rule for r8152 driver
In the current kernel the r8152 driver is *never* built because of a missing rule in drivers/net/Makefile, despite being selected as built-in or module in the .config file. There is no error message or warning to indicate that the driver isn't built. This change adds the rule and lets the driver build.
Tested as built-in and module for 3.15.8.
Signed-off by: JF Le Fillatre <jflf-kernel@gmx.com>
---
Is seems that this issue has existed ever since the driver was added back in 3.10. In Linus' git tree the drivers/net/Makefile was last modified before the inclusion of the driver, so I don't know if it's ever been possible to build it.
--- linux-3.15.8/drivers/net/Makefile.orig 2014-08-01 21:51:43.058347887 +0200
+++ linux-3.15.8/drivers/net/Makefile 2014-08-01 21:52:15.418345294 +0200
@@ -65,6 +65,7 @@ obj-$(CONFIG_USB_CATC) += usb/
obj-$(CONFIG_USB_KAWETH) += usb/
obj-$(CONFIG_USB_PEGASUS) += usb/
obj-$(CONFIG_USB_RTL8150) += usb/
+obj-$(CONFIG_USB_RTL8152) += usb/
obj-$(CONFIG_USB_HSO) += usb/
obj-$(CONFIG_USB_USBNET) += usb/
obj-$(CONFIG_USB_ZD1201) += usb/
next reply other threads:[~2014-08-01 23:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 23:26 jflf-kernel [this message]
2014-08-03 3:41 ` [PATCH] r8152: add missing Makefile rule David Miller
2014-08-03 7:52 ` jflf-kernel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53DC2230.9010504@gmx.com \
--to=jflf-kernel@gmx.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).