* [PATCH] r8152: add missing Makefile rule
@ 2014-08-01 23:26 jflf-kernel
2014-08-03 3:41 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: jflf-kernel @ 2014-08-01 23:26 UTC (permalink / raw)
To: nic_swsd; +Cc: netdev
From: JF Le Fillatre <jflf-kernel@gmx.com>
Add missing Makefile rule for r8152 driver
In the current kernel the r8152 driver is *never* built because of a missing rule in drivers/net/Makefile, despite being selected as built-in or module in the .config file. There is no error message or warning to indicate that the driver isn't built. This change adds the rule and lets the driver build.
Tested as built-in and module for 3.15.8.
Signed-off by: JF Le Fillatre <jflf-kernel@gmx.com>
---
Is seems that this issue has existed ever since the driver was added back in 3.10. In Linus' git tree the drivers/net/Makefile was last modified before the inclusion of the driver, so I don't know if it's ever been possible to build it.
--- linux-3.15.8/drivers/net/Makefile.orig 2014-08-01 21:51:43.058347887 +0200
+++ linux-3.15.8/drivers/net/Makefile 2014-08-01 21:52:15.418345294 +0200
@@ -65,6 +65,7 @@ obj-$(CONFIG_USB_CATC) += usb/
obj-$(CONFIG_USB_KAWETH) += usb/
obj-$(CONFIG_USB_PEGASUS) += usb/
obj-$(CONFIG_USB_RTL8150) += usb/
+obj-$(CONFIG_USB_RTL8152) += usb/
obj-$(CONFIG_USB_HSO) += usb/
obj-$(CONFIG_USB_USBNET) += usb/
obj-$(CONFIG_USB_ZD1201) += usb/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] r8152: add missing Makefile rule
2014-08-01 23:26 [PATCH] r8152: add missing Makefile rule jflf-kernel
@ 2014-08-03 3:41 ` David Miller
2014-08-03 7:52 ` jflf-kernel
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2014-08-03 3:41 UTC (permalink / raw)
To: jflf-kernel; +Cc: nic_swsd, netdev
From: jflf-kernel@gmx.com
Date: Sat, 02 Aug 2014 01:26:40 +0200
> Is seems that this issue has existed ever since the driver was
> added back in 3.10. In Linus' git tree the drivers/net/Makefile was
> last modified before the inclusion of the driver, so I don't know
> if it's ever been possible to build it.
It gets built, as long as at least one other USB networking driver has
been selected.
Most people (distributions, developers, maintainers) select all
drivers or some large subset thereof, so would never actually run into
this problem.
You'd have to specifically have a configuration that enabled r8152 and
no other USB networking driver, in order to trigger this.
Anyways, I'll apply this, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] r8152: add missing Makefile rule
2014-08-03 3:41 ` David Miller
@ 2014-08-03 7:52 ` jflf-kernel
0 siblings, 0 replies; 3+ messages in thread
From: jflf-kernel @ 2014-08-03 7:52 UTC (permalink / raw)
To: David Miller; +Cc: nic_swsd, netdev
On 03/08/14 05:41 AM, David Miller wrote:
> From: jflf-kernel@gmx.com
> Date: Sat, 02 Aug 2014 01:26:40 +0200
>
>> Is seems that this issue has existed ever since the driver was
>> added back in 3.10. In Linus' git tree the drivers/net/Makefile was
>> last modified before the inclusion of the driver, so I don't know
>> if it's ever been possible to build it.
>
> It gets built, as long as at least one other USB networking driver has
> been selected.
>
> Most people (distributions, developers, maintainers) select all
> drivers or some large subset thereof, so would never actually run into
> this problem.
>
> You'd have to specifically have a configuration that enabled r8152 and
> no other USB networking driver, in order to trigger this.
>
> Anyways, I'll apply this, thanks.
Very true, thank you for pointing it out. If you haven't done so yet,
the patch description could be changed to something like:
When it is the only USB net driver selected, the r8152 driver doesn't
get built because of a missing rule in drivers/net/Makefile. This change
adds the rule and lets the driver build.
Thank you!
JF
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-08-03 7:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-01 23:26 [PATCH] r8152: add missing Makefile rule jflf-kernel
2014-08-03 3:41 ` David Miller
2014-08-03 7:52 ` jflf-kernel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).