From: Zoltan Kiss <zoltan.kiss@citrix.com>
To: David Miller <davem@davemloft.net>
Cc: <steffen.klassert@secunet.com>, <minipli@googlemail.com>,
<dborkman@redhat.com>, <tgraf@suug.ch>, <joe@perches.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH net-next v4 4/4 RFC] pktgen: Allow sending IPv4 TCP packets
Date: Wed, 6 Aug 2014 19:09:40 +0100 [thread overview]
Message-ID: <53E26F64.6080301@citrix.com> (raw)
In-Reply-To: <20140805.130901.2116578415179622318.davem@davemloft.net>
On 05/08/14 21:09, David Miller wrote:
> From: Zoltan Kiss <zoltan.kiss@citrix.com>
> Date: Mon, 4 Aug 2014 14:37:14 +0100
>
>> @@ -3559,6 +3616,14 @@ static void pktgen_xmit(struct pktgen_dev *pkt_dev)
>> pkt_dev->last_pkt_size = pkt_dev->skb->len;
>> pkt_dev->allocated_skbs++;
>> pkt_dev->clone_count = 0; /* reset counter */
>> +
>> + if (netif_needs_gso(pkt_dev->skb, netif_skb_features(pkt_dev->skb))) {
>> + pr_err("Device don't have necessary GSO features! netif_skb_features: %llX summed %u\n",
>> + netif_skb_features(pkt_dev->skb),
>> + pkt_dev->skb->ip_summed);
>> + pkt_dev->sofar++;
>> + goto out;
>> + }
>> }
>>
>> if (pkt_dev->delay && pkt_dev->last_ok)
>
> Woe be to the person who actually triggers this condition. This function
> happens potentially millions of times per second, there is no value in
> emitting a log message every time.
Indeed, I'll put a ratelimit around it.
Zoli
prev parent reply other threads:[~2014-08-06 18:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 13:37 [PATCH net-next v4 0/3] pktgen: Upstreaming features useful for xen-netback/front testing Zoltan Kiss
2014-08-04 13:37 ` [PATCH net-next 1/4 v5] pktgen: Fill the payload optionally with a pattern Zoltan Kiss
2014-08-04 13:37 ` [PATCH net-next v3 2/4] pktgen: Allow setting frag sizes individually Zoltan Kiss
2014-08-04 13:37 ` [PATCH net-next 3/4 RFC] pktgen: Fixing UPD checksum calculation Zoltan Kiss
2014-08-04 13:37 ` [PATCH net-next v4 4/4 RFC] pktgen: Allow sending IPv4 TCP packets Zoltan Kiss
2014-08-05 20:09 ` David Miller
2014-08-06 18:09 ` Zoltan Kiss [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E26F64.6080301@citrix.com \
--to=zoltan.kiss@citrix.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minipli@googlemail.com \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=tgraf@suug.ch \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).