From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Mack Subject: Re: [PATCH] drivers: net: davinci_cpdma: drop devm_kfree of devm_kzalloc'd data Date: Sun, 10 Aug 2014 22:26:47 +0200 Message-ID: <53E7D587.9040303@gmail.com> References: <20140810195819.GA3880@himangi-Dell> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Julia Lawall To: Himangi Saraogi , "David S. Miller" , Olof Johansson , Dan Carpenter , Felipe Balbi , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Return-path: Received: from mail-we0-f173.google.com ([74.125.82.173]:50887 "EHLO mail-we0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751138AbaHJU1B (ORCPT ); Sun, 10 Aug 2014 16:27:01 -0400 In-Reply-To: <20140810195819.GA3880@himangi-Dell> Sender: netdev-owner@vger.kernel.org List-ID: On 08/10/2014 09:58 PM, Himangi Saraogi wrote: > devm_kfree should not have to be explicitly used. > > The Coccinelle semantic patch that fixes this problem is as follows: > > // > @@ > expression x,d; > @@ > > x = devm_kzalloc(...) > ... > ?-devm_kfree(d,x); > // > > Signed-off-by: Himangi Saraogi > Acked-by: Julia Lawall Acked-by: Daniel Mack However, you need to resend this patch after 3.17-rc1 has been released and the net-next branch was opened again. Thanks, Daniel > --- > drivers/net/ethernet/ti/davinci_cpdma.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ethernet/ti/davinci_cpdma.c b/drivers/net/ethernet/ti/davinci_cpdma.c > index 4a000f6..af673f5 100644 > --- a/drivers/net/ethernet/ti/davinci_cpdma.c > +++ b/drivers/net/ethernet/ti/davinci_cpdma.c > @@ -512,7 +512,6 @@ struct cpdma_chan *cpdma_chan_create(struct cpdma_ctlr *ctlr, int chan_num, > spin_lock_irqsave(&ctlr->lock, flags); > if (ctlr->channels[chan_num]) { > spin_unlock_irqrestore(&ctlr->lock, flags); > - devm_kfree(ctlr->dev, chan); > return ERR_PTR(-EBUSY); > } > >