From: David Vrabel <david.vrabel@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>, Zoltan Kiss <zoltan.kiss@citrix.com>
Cc: <netdev@vger.kernel.org>, Ian Campbell <ian.campbell@citrix.com>,
David Vrabel <david.vrabel@citrix.com>, <xen-devel@lists.xen.org>
Subject: Re: [Xen-devel] [PATCH net v2 1/3] xen-netback: move NAPI add/remove calls
Date: Mon, 11 Aug 2014 14:59:52 +0100 [thread overview]
Message-ID: <53E8CC58.10904@citrix.com> (raw)
In-Reply-To: <20140811134322.GE3249@zion.uk.xensource.com>
On 11/08/14 14:43, Wei Liu wrote:
> In short, there's no need to reorder disconnect logic and no need have a
> dedicated loop for netif_napi_del.
Not for now. But I would prefer it if it was re-ordered. And similarly
in xenvif_down(), irq_disable() should be before napi_disable().
David
next prev parent reply other threads:[~2014-08-11 13:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-08 16:37 [PATCH net v2 0/3] xen-netback: synchronisation between core driver and netback Wei Liu
2014-08-08 16:37 ` [PATCH net v2 1/3] xen-netback: move NAPI add/remove calls Wei Liu
2014-08-08 16:49 ` Sergei Shtylyov
2014-08-08 16:52 ` Wei Liu
2014-08-11 12:35 ` [Xen-devel] " David Vrabel
2014-08-11 12:49 ` Zoltan Kiss
2014-08-11 13:01 ` David Vrabel
2014-08-11 13:14 ` Zoltan Kiss
2014-08-11 13:43 ` Wei Liu
2014-08-11 13:59 ` David Vrabel [this message]
2014-08-11 14:08 ` Wei Liu
2014-08-08 16:37 ` [PATCH net v2 2/3] xen-netback: don't stop dealloc kthread too early Wei Liu
2014-08-11 12:10 ` [Xen-devel] " David Vrabel
2014-08-11 13:48 ` Wei Liu
2014-08-11 13:58 ` David Vrabel
2014-08-11 14:13 ` Zoltan Kiss
2014-08-11 14:44 ` Wei Liu
2014-08-11 15:23 ` David Vrabel
2014-08-11 20:39 ` Wei Liu
2014-08-11 14:31 ` Wei Liu
2014-08-11 14:34 ` David Vrabel
2014-08-11 14:39 ` Wei Liu
2014-08-08 16:37 ` [PATCH net v2 3/3] xen-netback: remove loop waiting function Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E8CC58.10904@citrix.com \
--to=david.vrabel@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=netdev@vger.kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=zoltan.kiss@citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).