From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Borkmann Subject: Re: [PATCH] Made bpf_internal_load_pointer_neg_helper static: fixes Sparse warning Date: Tue, 12 Aug 2014 07:21:20 +0200 Message-ID: <53E9A450.7070608@redhat.com> References: <1405708449.11800.2.camel@oc1318858833.ibm.com> <1407794456.12335.3.camel@oc1318858833.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Benjamin Lee , "netdev@vger.kernel.org" , "David S. Miller" , "linux-kernel@vger.kernel.org" , dany@us.ibm.com, dany4madden@gmail.com, benjamin.fik.lee@gmail.com To: Alexei Starovoitov Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 08/12/2014 02:57 AM, Alexei Starovoitov wrote: > On Mon, Aug 11, 2014 at 3:00 PM, Benjamin Lee wrote: >> I wanted to know what the current status of my patch is since my >> internship will be ending this Friday and I want to know before then. if >> there are any problems with it I can fix them before Thursday. Thank you >> in advance. > > using scripts/get_maintainer.pl for cc list would have helped to > receive response sooner. > >> On Fri, 2014-07-18 at 11:34 -0700, Benjamin Lee wrote: >>> This patch fixes the following Sparse warning: >>> >>> net/core/filter.c:52:6: warning: symbol >>> 'bpf_internal_load_pointer_neg_helper' was not declared. Should it be >>> static? >>> >>> I declared bpf_internal_load_pointer_neg_helper as static because it >>> is not referenced elsewhere in the kernel. The patched kernel boots > > the patch is incorrect, since this function is called out of assembler. > Try 'git grep bpf_internal_load_pointer_neg_helper' Agreed.