From: Hyong-Youb Kim <hyong-youb.kim@myricom.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>, <netdev@vger.kernel.org>
Cc: Hyong-Youb Kim <hykim@myri.com>
Subject: Re: [PATCH v2] myri10ge: check for DMA mapping errors
Date: Tue, 12 Aug 2014 19:04:24 +0900 [thread overview]
Message-ID: <53E9E6A8.2060908@myricom.com> (raw)
In-Reply-To: <20140812083518.GA1836@redhat.com>
On 8/12/2014 5:35 PM, Stanislaw Gruszka wrote:
> On IOMMU systems DMA mapping can fail, we need to check for
> that possibility.
>
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
> ---
> v1 -> v2: check also for errors on myri10ge_xmit()
It looks okay to me.
> abort_linearize:
[...]
> - tx->info[idx].skb = NULL;
I think this last line was a bug. Thanks for fixing this too. It would
lead the code below to call pci_unmap_page() on the header buffer. It
should call pci_unmap_single() instead.
> - do {
[...]
> - if (tx->info[idx].skb != NULL)
> - pci_unmap_single(mgp->pdev,
[...]
> - else
> - pci_unmap_page(mgp->pdev,
next prev parent reply other threads:[~2014-08-12 10:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-12 8:35 [PATCH v2] myri10ge: check for DMA mapping errors Stanislaw Gruszka
2014-08-12 10:04 ` Hyong-Youb Kim [this message]
2014-08-12 21:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E9E6A8.2060908@myricom.com \
--to=hyong-youb.kim@myricom.com \
--cc=hykim@myri.com \
--cc=netdev@vger.kernel.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).