* [PATCH 2/2] lec: Fix bug introduced by b67bfe0d42cac56c512dd5da4b1b347a23f4b70a
@ 2014-08-12 12:24 chas williams - CONTRACTOR
2014-08-12 12:34 ` Sergei Shtylyov
0 siblings, 1 reply; 4+ messages in thread
From: chas williams - CONTRACTOR @ 2014-08-12 12:24 UTC (permalink / raw)
To: netdev, linux-atm-general
b67bfe0d42cac56c512dd5da4b1b347a23f4b70a dropped the node parameters
from iterators which lec_tbl_walk() was using to iterate the list.
Signed-off-by: Chas Williams <chas@cmf.nrl.navy.mil>
---
net/atm/lec.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/net/atm/lec.c b/net/atm/lec.c
index 4c5b8ba..e4853b5 100644
--- a/net/atm/lec.c
+++ b/net/atm/lec.c
@@ -833,7 +833,6 @@ static void *lec_tbl_walk(struct lec_state *state, struct hlist_head *tbl,
loff_t *l)
{
struct hlist_node *e = state->node;
- struct lec_arp_table *tmp;
if (!e)
e = tbl->first;
@@ -842,9 +841,7 @@ static void *lec_tbl_walk(struct lec_state *state, struct hlist_head *tbl,
--*l;
}
- tmp = container_of(e, struct lec_arp_table, next);
-
- hlist_for_each_entry_from(tmp, next) {
+ for (; e; e = e->next) {
if (--*l < 0)
break;
}
--
1.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] lec: Fix bug introduced by b67bfe0d42cac56c512dd5da4b1b347a23f4b70a
2014-08-12 12:24 [PATCH 2/2] lec: Fix bug introduced by b67bfe0d42cac56c512dd5da4b1b347a23f4b70a chas williams - CONTRACTOR
@ 2014-08-12 12:34 ` Sergei Shtylyov
2014-08-12 13:00 ` [PATCH] " chas williams - CONTRACTOR
0 siblings, 1 reply; 4+ messages in thread
From: Sergei Shtylyov @ 2014-08-12 12:34 UTC (permalink / raw)
To: chas williams - CONTRACTOR, netdev, linux-atm-general
Hello.
On 8/12/2014 4:24 PM, chas williams - CONTRACTOR wrote:
> b67bfe0d42cac56c512dd5da4b1b347a23f4b70a dropped the node parameters
Please also specify that commit's summary line in parens.
> from iterators which lec_tbl_walk() was using to iterate the list.
> Signed-off-by: Chas Williams <chas@cmf.nrl.navy.mil>
WBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] lec: Fix bug introduced by b67bfe0d42cac56c512dd5da4b1b347a23f4b70a
2014-08-12 12:34 ` Sergei Shtylyov
@ 2014-08-12 13:00 ` chas williams - CONTRACTOR
2014-08-12 22:02 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: chas williams - CONTRACTOR @ 2014-08-12 13:00 UTC (permalink / raw)
Cc: netdev, linux-atm-general
b67bfe0d42cac56c512dd5da4b1b347a23f4b70a (hlist: drop the node
parameter from iterators) dropped the node parameter from
iterators which lec_tbl_walk() was using to iterate the list.
Signed-off-by: Chas Williams <chas@cmf.nrl.navy.mil>
---
net/atm/lec.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/net/atm/lec.c b/net/atm/lec.c
index 4c5b8ba..e4853b5 100644
--- a/net/atm/lec.c
+++ b/net/atm/lec.c
@@ -833,7 +833,6 @@ static void *lec_tbl_walk(struct lec_state *state, struct hlist_head *tbl,
loff_t *l)
{
struct hlist_node *e = state->node;
- struct lec_arp_table *tmp;
if (!e)
e = tbl->first;
@@ -842,9 +841,7 @@ static void *lec_tbl_walk(struct lec_state *state, struct hlist_head *tbl,
--*l;
}
- tmp = container_of(e, struct lec_arp_table, next);
-
- hlist_for_each_entry_from(tmp, next) {
+ for (; e; e = e->next) {
if (--*l < 0)
break;
}
--
1.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] lec: Fix bug introduced by b67bfe0d42cac56c512dd5da4b1b347a23f4b70a
2014-08-12 13:00 ` [PATCH] " chas williams - CONTRACTOR
@ 2014-08-12 22:02 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2014-08-12 22:02 UTC (permalink / raw)
To: chas; +Cc: netdev, linux-atm-general
From: chas williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
Date: Tue, 12 Aug 2014 09:00:36 -0400
> b67bfe0d42cac56c512dd5da4b1b347a23f4b70a (hlist: drop the node
> parameter from iterators) dropped the node parameter from
> iterators which lec_tbl_walk() was using to iterate the list.
>
> Signed-off-by: Chas Williams <chas@cmf.nrl.navy.mil>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-08-12 22:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-12 12:24 [PATCH 2/2] lec: Fix bug introduced by b67bfe0d42cac56c512dd5da4b1b347a23f4b70a chas williams - CONTRACTOR
2014-08-12 12:34 ` Sergei Shtylyov
2014-08-12 13:00 ` [PATCH] " chas williams - CONTRACTOR
2014-08-12 22:02 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).