From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Eli Cohen <eli@dev.mellanox.co.il>,
roland@kernel.org, davem@davemloft.net
Cc: netdev@vger.kernel.org, rdma@vger.kernel.org, amirv@mellanox.com,
yevgenyp@mellanox.com, Eli Cohen <eli@mellanox.com>
Subject: Re: [PATCH net-next 02/10] IB/mlx5: Add support for extended query device
Date: Wed, 13 Aug 2014 16:29:00 +0400 [thread overview]
Message-ID: <53EB5A0C.8040209@cogentembedded.com> (raw)
In-Reply-To: <1407929951-16362-3-git-send-email-eli@mellanox.com>
Hello.
On 8/13/2014 3:39 PM, Eli Cohen wrote:
> Add a new entry for query device extended which currently has identical
> functionality to query_device and publish support for it.
> Signed-off-by: Eli Cohen <eli@mellanox.com>
> ---
> drivers/infiniband/hw/mlx5/main.c | 25 +++++++++++++++++++++++--
> 1 file changed, 23 insertions(+), 2 deletions(-)
> diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c
> index d8907b20522a..63fddeec90af 100644
> --- a/drivers/infiniband/hw/mlx5/main.c
> +++ b/drivers/infiniband/hw/mlx5/main.c
[...]
> @@ -775,6 +781,17 @@ static int mlx5_ib_dealloc_pd(struct ib_pd *pd)
> return 0;
> }
>
> +static int mlx5_ib_query_device_ex(struct ib_device *device,
> + struct ib_device_attr *attr,
> + struct ib_udata *uhw)
> +{
> + int err;
> +
> + err = query_device(device, attr);
> +
> + return err;
> +}
Why not just:
return query_device(device, attr);
WBR, Sergei
next prev parent reply other threads:[~2014-08-13 12:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 11:39 [PATCH net-next 00/10] IB core and mlx5 changes Eli Cohen
2014-08-13 11:39 ` [PATCH net-next 01/10] IB/core: Add support for extended query device caps Eli Cohen
2014-08-13 11:39 ` [PATCH net-next 02/10] IB/mlx5: Add support for extended query device Eli Cohen
2014-08-13 12:29 ` Sergei Shtylyov [this message]
2014-08-13 13:49 ` Eli Cohen
2014-08-13 11:39 ` [PATCH net-next 03/10] mlx5: Use hardware registers description header file Eli Cohen
2014-08-13 11:39 ` [PATCH net-next 04/10] IB/mlx5: Remove duplicate code from mlx5_set_path Eli Cohen
2014-08-13 11:39 ` [PATCH net-next 05/10] IB/core: Define big endian response for atomic operations Eli Cohen
2014-08-13 11:39 ` [PATCH net-next 06/10] IB/mlx5: Add extended atomic support Eli Cohen
2014-08-13 11:39 ` [PATCH net-next 07/10] IB/mlx4: " Eli Cohen
2014-08-13 11:39 ` [PATCH net-next 08/10] IB/mlx5: Clear umr resources after ib_unregister_device Eli Cohen
2014-08-13 11:39 ` [PATCH net-next 09/10] IB/mlx5: Improve debug prints in mlx5_ib_reg_user_mr Eli Cohen
2014-08-13 11:39 ` [PATCH net-next 10/10] IB/core: Avoid leakage from kernel to user space Eli Cohen
2014-08-13 19:44 ` [PATCH net-next 00/10] IB core and mlx5 changes David Miller
2014-08-13 19:47 ` Eli Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53EB5A0C.8040209@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=amirv@mellanox.com \
--cc=davem@davemloft.net \
--cc=eli@dev.mellanox.co.il \
--cc=eli@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=rdma@vger.kernel.org \
--cc=roland@kernel.org \
--cc=yevgenyp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).