From: Daniel Mack <zonque@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
stable@vger.kernel.org
Subject: Re: [PATCH] net: smsc911x: handle suspend/resume for mii bus
Date: Wed, 13 Aug 2014 22:14:32 +0200 [thread overview]
Message-ID: <53EBC728.4000602@gmail.com> (raw)
In-Reply-To: <CAOMZO5CJ+FejN38Kn-=iKor5GzNHAA7bOdK-mMKJ+nqqBXqAXg@mail.gmail.com>
Hi Fabio,
On 08/13/2014 10:09 PM, Fabio Estevam wrote:
> On Wed, Aug 13, 2014 at 5:03 PM, Daniel Mack <zonque@gmail.com> wrote:
>> Since commit a71e3c37960c ("net: phy: Set the driver when registering
>> an MDIO bus device"), the ->driver pointers of all mii buses are set to
>> the parent device's driver. This means that smsc911x_{suspend,resume}
>> will be called for the MII bus at suspend time now, in addition to the
>> actual netdev suspend callbacks.
>
> This commit has been reverted in mainline:
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/net/phy/mdio_bus.c?id=ce7991e8198b80eb6b4441b6f6114bea4a665d66
>
Ah, same conclusion there, so all's good :)
Thanks for the pointer, and please drop my patch then.
Daniel
prev parent reply other threads:[~2014-08-13 20:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 20:03 [PATCH] net: smsc911x: handle suspend/resume for mii bus Daniel Mack
2014-08-13 20:09 ` Fabio Estevam
2014-08-13 20:14 ` Daniel Mack [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53EBC728.4000602@gmail.com \
--to=zonque@gmail.com \
--cc=davem@davemloft.net \
--cc=ezequiel.garcia@free-electrons.com \
--cc=f.fainelli@gmail.com \
--cc=festevam@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).