From: Marc Kleine-Budde <mkl@pengutronix.de>
To: weiyj_lk@163.com, Wolfgang Grandegger <wg@grandegger.com>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Chen Gang <gang.chen@asianux.com>,
George Cherian <george.cherian@ti.com>,
Sachin Kamat <sachin.kamat@linaro.org>,
"Lad, Prabhakar" <prabhakar.csengg@gmail.com>,
Pavel Machek <pavel@denx.de>, Thor Thayer <tthayer@altera.com>,
Mugunthan V N <mugunthanvnm@ti.com>,
Wolfram Sang <wsa@sang-engineering.com>
Cc: Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
linux-can@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] can: c_can: Fix return value check in c_can_plat_probe()
Date: Thu, 14 Aug 2014 12:11:35 +0200 [thread overview]
Message-ID: <53EC8B57.6070300@pengutronix.de> (raw)
In-Reply-To: <1407977939-15287-1-git-send-email-weiyj_lk@163.com>
[-- Attachment #1: Type: text/plain, Size: 741 bytes --]
On 08/14/2014 02:58 AM, weiyj_lk@163.com wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> In case of error, the function devm_ioremap() returns NULL pointer
> not ERR_PTR(). The IS_ERR() test in the return value check should
> be replaced with NULL test.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Dan Carpenter already provided this fix. It will be included in my next
pull request to David's net.
Thanks,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
prev parent reply other threads:[~2014-08-14 10:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 0:58 [PATCH] can: c_can: Fix return value check in c_can_plat_probe() weiyj_lk
2014-08-14 10:11 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53EC8B57.6070300@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=gang.chen@asianux.com \
--cc=george.cherian@ti.com \
--cc=grant.likely@linaro.org \
--cc=linux-can@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=pavel@denx.de \
--cc=prabhakar.csengg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sachin.kamat@linaro.org \
--cc=tglx@linutronix.de \
--cc=tthayer@altera.com \
--cc=weiyj_lk@163.com \
--cc=wg@grandegger.com \
--cc=wsa@sang-engineering.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).