From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: Shmulik Ladkani <shmulik.ladkani@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Cc: Sascha Hlusiak <contact@saschahlusiak.de>
Subject: Re: [PATCH] sit: Fix ipip6_tunnel_lookup device matching criteria
Date: Thu, 14 Aug 2014 12:17:05 +0200 [thread overview]
Message-ID: <53EC8CA1.6060909@6wind.com> (raw)
In-Reply-To: <1408008729-16982-1-git-send-email-shmulik.ladkani@gmail.com>
Le 14/08/2014 11:32, Shmulik Ladkani a écrit :
> As of 4fddbf5d78, when looking up a tunnel, tunnel's underlying
Please, put also the subject of the commit like this:
4fddbf5d7854 ("sit: strictly restrict incoming traffic to tunnel link device")
> interface (t->parms.link) is verified to match incoming traffic's
> ingress device.
>
> However the comparison was incorrectly based on skb->dev->iflink.
>
> Instead, dev->ifindex should be used, which correctly represents the
> interface from which the IP stack hands the ipip6 packets.
>
> This allows setting up sit tunnels bound to vlan interfaces (otherwise
> incoming ipip6 traffic on the vlan interface was dropped due to
> ipip6_tunnel_lookup match failure).
>
> Signed-off-by: Shmulik Ladkani <shmulik.ladkani@gmail.com>
Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
next prev parent reply other threads:[~2014-08-14 10:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 9:32 [PATCH] sit: Fix ipip6_tunnel_lookup device matching criteria Shmulik Ladkani
2014-08-14 10:17 ` Nicolas Dichtel [this message]
2014-08-14 10:49 ` [PATCH v2] " Shmulik Ladkani
2014-08-14 12:03 ` Nicolas Dichtel
2014-08-14 12:08 ` [PATCH] " Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53EC8CA1.6060909@6wind.com \
--to=nicolas.dichtel@6wind.com \
--cc=contact@saschahlusiak.de \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shmulik.ladkani@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).