From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Fastabend Subject: Re: [PATCH] macvlan: Allow setting multicast filter on all macvlan types Date: Fri, 15 Aug 2014 12:04:28 -0700 Message-ID: <53EE59BC.1070605@intel.com> References: <1408122299-29632-1-git-send-email-vyasevic@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "Michael S. Tsirkin" , Jason Wang , roopa@cumulusnetworks.com To: Vladislav Yasevich , netdev@vger.kernel.org Return-path: Received: from mga01.intel.com ([192.55.52.88]:34689 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751210AbaHOTKR (ORCPT ); Fri, 15 Aug 2014 15:10:17 -0400 In-Reply-To: <1408122299-29632-1-git-send-email-vyasevic@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: On 08/15/2014 10:04 AM, Vladislav Yasevich wrote: > Currently, macvlan code restricts multicast and unicast > filter setting only to passthru devices. As a result, > if a guest using macvtap wants to receive multicast > traffic, it has to set IFF_ALLMULTI or IFF_PROMISC. > > This patch makes it possible to use the fdb interface > to add multicast addresses to the filter thus allowing > a guest to receive only targeted multicast traffic. > > CC: John Fastabend > CC: Michael S. Tsirkin > CC: Jason Wang > Signed-off-by: Vladislav Yasevich > --- Acked-by: John Fastabend Looks good to me. Although I am trying to recall why we restrict unicast addresses? It looks like an additional check could be made to detect duplicate MAC addresses in fdb_add and then we could support this as well. But I might be missing why this wasn't supported originally. Thanks, John