From: Daniel Borkmann <dborkman@redhat.com>
To: Alexei Starovoitov <ast@plumgrid.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Brendan Gregg <brendan.d.gregg@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] bpf: x86: add missing 'shift by register' instructions to x64 eBPF JIT
Date: Mon, 25 Aug 2014 21:39:35 +0200 [thread overview]
Message-ID: <53FB90F7.1000701@redhat.com> (raw)
In-Reply-To: <1408994822-14929-1-git-send-email-ast@plumgrid.com>
On 08/25/2014 09:27 PM, Alexei Starovoitov wrote:
> 'shift by register' operations are supported by eBPF interpreter, but were
> accidently left out of x64 JIT compiler. Fix it and add a testcase.
>
> Reported-by: Brendan Gregg <brendan.d.gregg@gmail.com>
> Signed-off-by: Alexei Starovoitov <ast@plumgrid.com>
> Fixes: 622582786c9e ("net: filter: x86: internal BPF JIT")
> ---
>
> Probably not worth sending to stable, but wouldn't hurt either.
Then I guess this should be against -net tree then.
I guess implications were only fallback to interpreter, right?
next prev parent reply other threads:[~2014-08-25 19:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-25 19:27 [PATCH net-next] bpf: x86: add missing 'shift by register' instructions to x64 eBPF JIT Alexei Starovoitov
2014-08-25 19:39 ` Daniel Borkmann [this message]
2014-08-25 19:43 ` Alexei Starovoitov
2014-08-26 0:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FB90F7.1000701@redhat.com \
--to=dborkman@redhat.com \
--cc=ast@plumgrid.com \
--cc=brendan.d.gregg@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hpa@zytor.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).