From: Randy Dunlap <rdunlap@infradead.org>
To: "linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>
Cc: Jim Davis <jim.epost@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Ariel Elior <ariel.elior@qlogic.com>
Subject: Re: [PATCH] net: bnx2x: fix build error with ptp
Date: Mon, 25 Aug 2014 13:14:08 -0700 [thread overview]
Message-ID: <53FB9910.3020601@infradead.org> (raw)
In-Reply-To: <53FB9884.8000707@infradead.org>
Note: This patch fixes a build error in linux-next (not in mainline).
On 08/25/14 13:11, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> bnx2x uses ptp functions, so it should select the provider of
> those functions (PTP_1588_CLOCK). Fixes these build errors:
>
> drivers/built-in.o: In function `__bnx2x_remove':
> /home/jim/linux/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:13409:
> undefined reference to `ptp_clock_unregister'
> drivers/built-in.o: In function `bnx2x_register_phc':
> /home/jim/linux/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:13202:
> undefined reference to `ptp_clock_register'
> drivers/built-in.o: In function `bnx2x_get_ts_info':
> /home/jim/linux/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c:3498:
> undefined reference to `ptp_clock_index'
>
> Reported-by: Jim Davis <jim.epost@gmail.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> drivers/net/ethernet/broadcom/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> Index: linux-next-20140825/drivers/net/ethernet/broadcom/Kconfig
> ===================================================================
> --- linux-next-20140825.orig/drivers/net/ethernet/broadcom/Kconfig
> +++ linux-next-20140825/drivers/net/ethernet/broadcom/Kconfig
> @@ -122,6 +122,7 @@ config TIGON3
> config BNX2X
> tristate "Broadcom NetXtremeII 10Gb support"
> depends on PCI
> + select PTP_1588_CLOCK
> select FW_LOADER
> select ZLIB_INFLATE
> select LIBCRC32C
> --
--
~Randy
next prev parent reply other threads:[~2014-08-25 20:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-25 20:11 [PATCH] net: bnx2x: fix build error with ptp Randy Dunlap
2014-08-25 20:14 ` Randy Dunlap [this message]
2014-08-26 0:37 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FB9910.3020601@infradead.org \
--to=rdunlap@infradead.org \
--cc=ariel.elior@qlogic.com \
--cc=davem@davemloft.net \
--cc=jim.epost@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).