From mboxrd@z Thu Jan 1 00:00:00 1970 From: Giuseppe CAVALLARO Subject: Re: [PATCH] net: stmmac: fix warning from Sparse for socfpga Date: Tue, 26 Aug 2014 09:24:46 +0200 Message-ID: <53FC363E.6050604@st.com> References: <1409037076-14775-1-git-send-email-lftan@altera.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Cc: , Vince Bridgers To: Ley Foon Tan , , , "David S. Miller" Return-path: In-Reply-To: <1409037076-14775-1-git-send-email-lftan@altera.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 8/26/2014 9:11 AM, Ley Foon Tan wrote: > Warning: > drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c:122:41: > sparse: cast removes address space of expression > drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c:122:38: > sparse: incorrect type in assignment (different address spaces) > > Signed-off-by: Ley Foon Tan > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c > index cd613d7..c1addce 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c > @@ -119,7 +119,8 @@ static int socfpga_dwmac_parse_data(struct socfpga_dwmac *dwmac, struct device * > return -EINVAL; > } > > - dwmac->splitter_base = (void *)devm_ioremap_resource(dev, > + dwmac->splitter_base = > + (void __iomem *)devm_ioremap_resource(dev, I think, no casting should be done: dwmac->splitter_base = devm_ioremap_resource(dev, .... patch should be for net-next peppe > &res_splitter); > if (!dwmac->splitter_base) { > dev_info(dev, "Failed to mapping emac splitter\n"); >