From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
To: Ley Foon Tan <lftan@altera.com>
Cc: <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Vince Bridgers <vbridger@altera.com>
Subject: Re: [PATCH] net: stmmac: fix warning from Sparse for socfpga
Date: Tue, 26 Aug 2014 10:04:25 +0200 [thread overview]
Message-ID: <53FC3F89.9030406@st.com> (raw)
In-Reply-To: <CAFiDJ5_LspyDPnXnimZ=TRiZD191XQRvwqgfZSOU-ziu_DUx=Q@mail.gmail.com>
On 8/26/2014 9:47 AM, Ley Foon Tan wrote:
> On Tue, Aug 26, 2014 at 3:24 PM, Giuseppe CAVALLARO
> <peppe.cavallaro@st.com> wrote:
>>> @@ -119,7 +119,8 @@ static int socfpga_dwmac_parse_data(struct
>>> socfpga_dwmac *dwmac, struct device *
>>> return -EINVAL;
>>> }
>>>
>>> - dwmac->splitter_base = (void *)devm_ioremap_resource(dev,
>>> + dwmac->splitter_base =
>>> + (void __iomem *)devm_ioremap_resource(dev,
>>
>>
>> I think, no casting should be done:
>>
>> dwmac->splitter_base = devm_ioremap_resource(dev, ....
> Oh ya, since both are same type. Will send new patch.
thx a lot
>
>>
>> patch should be for net-next
> Do you mean the patch need based on net-next git?
yes I do.
> I'm using linux-next git now.
ok, can you signal it in the subject (e.g. [PATCH (net-next)]
This can help on reviewing and IIRC required by Maintainer too
>
> Thanks.
welcome
BR
peppe
> Regards
> Ley Foon
>
>
next prev parent reply other threads:[~2014-08-26 8:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 7:11 [PATCH] net: stmmac: fix warning from Sparse for socfpga Ley Foon Tan
2014-08-26 7:24 ` Giuseppe CAVALLARO
2014-08-26 7:47 ` Ley Foon Tan
2014-08-26 8:04 ` Giuseppe CAVALLARO [this message]
2014-08-26 8:11 ` Ley Foon Tan
2014-08-27 23:33 ` David Miller
2014-08-28 3:33 ` Ley Foon Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FC3F89.9030406@st.com \
--to=peppe.cavallaro@st.com \
--cc=davem@davemloft.net \
--cc=lftan@altera.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vbridger@altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).