From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
To: Ley Foon Tan <lftan@altera.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>
Cc: <lftan.linux@gmail.com>, Vince Bridgers <vbridger@altera.com>
Subject: Re: [PATCH (net-next) v2] net: stmmac: fix warning from Sparse for socfpga
Date: Tue, 26 Aug 2014 12:13:35 +0200 [thread overview]
Message-ID: <53FC5DCF.4060202@st.com> (raw)
In-Reply-To: <1409046479-18546-1-git-send-email-lftan@altera.com>
On 8/26/2014 11:47 AM, Ley Foon Tan wrote:
> Warning:
> drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c:122:41:
> sparse: cast removes address space of expression
> drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c:122:38:
> sparse: incorrect type in assignment (different address spaces)
>
> Signed-off-by: Ley Foon Tan <lftan@altera.com>
> ---
> drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
> index cd613d7..ff54a1f 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
> @@ -119,7 +119,7 @@ static int socfpga_dwmac_parse_data(struct socfpga_dwmac *dwmac, struct device *
> return -EINVAL;
> }
>
> - dwmac->splitter_base = (void *)devm_ioremap_resource(dev,
> + dwmac->splitter_base = devm_ioremap_resource(dev,
> &res_splitter);
can the ioremap call stay in a single line ? or pls review indent looks
NOK
peppe
> if (!dwmac->splitter_base) {
> dev_info(dev, "Failed to mapping emac splitter\n");
>
next prev parent reply other threads:[~2014-08-26 10:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 9:47 [PATCH (net-next) v2] net: stmmac: fix warning from Sparse for socfpga Ley Foon Tan
2014-08-26 10:13 ` Giuseppe CAVALLARO [this message]
2014-08-27 1:24 ` Ley Foon Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FC5DCF.4060202@st.com \
--to=peppe.cavallaro@st.com \
--cc=davem@davemloft.net \
--cc=lftan.linux@gmail.com \
--cc=lftan@altera.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vbridger@altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).