From: Florian Fainelli <f.fainelli@gmail.com>
To: David Miller <davem@davemloft.net>, alexander.h.duyck@intel.com
Cc: netdev@vger.kernel.org, linville@tuxdriver.com, jhs@mojatatu.com,
alexander.duyck@gmail.com
Subject: Re: [PATCH net-next v4 01/13] net: dsa: reduce number of protocol hooks
Date: Wed, 27 Aug 2014 16:43:41 -0700 [thread overview]
Message-ID: <53FE6D2D.4060708@gmail.com> (raw)
In-Reply-To: <20140827.162458.878869941352643208.davem@davemloft.net>
On 08/27/2014 04:24 PM, David Miller wrote:
> From: Alexander Duyck <alexander.h.duyck@intel.com>
> Date: Wed, 27 Aug 2014 08:25:45 -0700
>
>> Just a thought, you might want to consider using a protocol value other
>> than ETH_P_DSA. Maybe we should add a new value named ETH_P_XDSA for
>> this approach since what we are doing is a multiplexed DSA protocol now.
>>
>> This would allow for much easier back-porting of this if needed and also
>> prevents us from possibly triggering any issues if there are any
>> user-space APIs that might be trying to capture packets based on the
>> protocol value.
>
> Agreed, Florian can you respin this patch set using a newly allocated
> ETH_P_* value for these new semantics?
Absolutely. While at it, I just realized that ETH_P_BRCMTAG should
probably remain within include/net/dsa.h. We don't want that to be
exported to user-space since it is used for internal DSA de-multiplexing.
Stay tuned!
--
Florian
next prev parent reply other threads:[~2014-08-27 23:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 4:49 [PATCH net-next v4 00/13] dsa: Broadcom Starfighter 2 switch support Florian Fainelli
2014-08-26 4:49 ` [PATCH net-next v4 01/13] net: dsa: reduce number of protocol hooks Florian Fainelli
2014-08-27 15:25 ` Alexander Duyck
2014-08-27 23:24 ` David Miller
2014-08-27 23:43 ` Florian Fainelli [this message]
2014-08-28 1:49 ` Alexander Duyck
2014-08-26 4:49 ` [PATCH net-next v4 02/13] net: phy: add generic UniMAC MDIO bus driver Florian Fainelli
2014-08-26 4:49 ` [PATCH net-next v4 03/13] net: phy: provide stub for fixed_phy_set_link_update Florian Fainelli
2014-08-26 4:49 ` [PATCH net-next v4 04/13] net: dsa: provide a switch device device tree node pointer Florian Fainelli
2014-08-26 4:49 ` [PATCH net-next v4 05/13] net: dsa: retain a per-port device_node pointer Florian Fainelli
2014-08-26 4:49 ` [PATCH net-next v4 06/13] net: dsa: allow for more complex PHY setups Florian Fainelli
2014-08-26 4:49 ` [PATCH net-next v4 07/13] net: dsa: allow switches to work without tagging Florian Fainelli
2014-08-26 4:49 ` [PATCH net-next v4 08/13] net: dsa: allow drivers to do link adjustment Florian Fainelli
2014-08-26 4:49 ` [PATCH net-next v4 09/13] net: dsa: allow updating fixed PHY link information Florian Fainelli
2014-08-26 4:49 ` [PATCH net-next v4 10/13] net: dsa: add Broadcom tag RX/TX handler Florian Fainelli
2014-08-26 4:49 ` [PATCH net-next v4 11/13] net: dsa: add Broadcom SF2 switch driver Florian Fainelli
2014-08-26 4:49 ` [PATCH net-next v4 12/13] Documentation: devicetree: update dsa binding with optional properties Florian Fainelli
2014-08-26 22:40 ` Sergei Shtylyov
2014-08-26 4:49 ` [PATCH net-next v4 13/13] Documentation: devicetree: add Broadcom Starfighter 2 binding Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FE6D2D.4060708@gmail.com \
--to=f.fainelli@gmail.com \
--cc=alexander.duyck@gmail.com \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).