From: Daniel Borkmann <dborkman@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: alexander.h.duyck@intel.com, netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next] ixgbe: flush when in xmit_more mode and under descriptor pressure
Date: Thu, 28 Aug 2014 13:46:09 +0200 [thread overview]
Message-ID: <53FF1681.7030406@redhat.com> (raw)
In-Reply-To: <20140827.231814.2270210172570593864.davem@davemloft.net>
On 08/28/2014 08:18 AM, David Miller wrote:
> From: Daniel Borkmann <dborkman@redhat.com>
> Date: Tue, 26 Aug 2014 19:34:18 +0200
>
>> When xmit_more mode is being used and the ring is about to
>> become full or the stack has stopped the ring, enforce a tail
>> pointer write to the hw. Otherwise, we could risk a TX hang.
>>
>> Code suggested by Alexander Duyck.
>>
>> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
>> Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
>> ---
>> v1->v2:
>> - Worked in Alex' feedback; in accordance w/ Alex, sending out v2
>> - Rerun tests, looks good
>
> Applied, thanks Daniel.
>
> I'll make similar mods to igb and vhost_net soon.
Cool, at some point later, we might want to put ...
netif_xmit_stopped(<tx_ring>) || !skb->xmit_more
... into an API perhaps, but that can likely wait right now.
prev parent reply other threads:[~2014-08-28 11:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 17:34 [PATCH v2 net-next] ixgbe: flush when in xmit_more mode and under descriptor pressure Daniel Borkmann
2014-08-28 6:18 ` David Miller
2014-08-28 11:46 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FF1681.7030406@redhat.com \
--to=dborkman@redhat.com \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).