From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F60A23E347 for ; Wed, 22 Oct 2025 08:05:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761120342; cv=none; b=kKu4cRUMJfKmtaKTHJaYfxrpE/jbr4o7vpiT3DSKvcACs0n2dloPTuWmupMK4zcyVcnITUTJDdzmvuG+0sz0YafKRpC+NFOJUuZsqN+I6F0lIDUGSskfJFqFTCmsBsfIvop2HtmYqTTbcGIUT5Ad7jYCydw1k5dKdyi82OTu1Rk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761120342; c=relaxed/simple; bh=kJTxADCnrPF0C0LvVodDKJ12ZmW8l1cU1TiDilEriAg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nOAwBjDSUvk2zPrW3PPG5h4Q6tH+8NqmM+OubqLc2A7UOwBVg2nIiOTC7ArrhafvvJ4xruCLDNnBgV53AkiSxEkgSbyJFUa1ZsP//3wv3itfOP7YXrvFa6YYrgcVPbPOtQhiVmqeQhJgOzZnX0dqo3+N2g08BK71VLFy71wWXDM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=D5jaGHRj; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="D5jaGHRj" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id A1DD14E41271; Wed, 22 Oct 2025 08:05:37 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 60537606DC; Wed, 22 Oct 2025 08:05:37 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id B2BE5102F2426; Wed, 22 Oct 2025 10:05:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1761120336; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=kBupXQ4ndi9PJAUUH78feYD9ZDDfnknJ54B3Giecuio=; b=D5jaGHRj29QBP6bpOSZhaQ3XytiuSkJYYMW1+84OY/eNXqaDbMIHwRSpoHyMyKFY/tp8pS kML5zTRiOWAHZ55gF8b4etMnOZque/NKLfhIPDbxlm2hLcGG9PzEU/Gp2jT5dVqC7xCdkw yB4dNuKpVKOCUSsf0cym7SXGT1T/nNjesUifJf0AWvoVCmDx6zjgyPYUJFLcbi3fo1Tj/r d3ND6scDT/T1LopE/idfcyu3VZkp2DS/62ofGZK58zj3ZT0nCp2FPSplaNxjy8ujbDvIF7 XfhpVS5DN5Ot2o3d+LJWjyETXm3wrxxynpc0hezYeiczQnXqD3j8+/XLPefWGQ== Message-ID: <53a53236-3cdf-420f-aa7e-6b00bc854b20@bootlin.com> Date: Wed, 22 Oct 2025 10:05:22 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v2 4/5] net: macb: rename bp->sgmii_phy field to bp->phy To: =?UTF-8?Q?Th=C3=A9o_Lebrun?= , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Nicolas Ferre , Claudiu Beznea , Russell King Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?Q?Beno=C3=AEt_Monin?= , =?UTF-8?Q?Gr=C3=A9gory_Clement?= , Tawfik Bayouk , Thomas Petazzoni , Vladimir Kondratiev References: <20251022-macb-eyeq5-v2-0-7c140abb0581@bootlin.com> <20251022-macb-eyeq5-v2-4-7c140abb0581@bootlin.com> From: Maxime Chevallier Content-Language: en-US In-Reply-To: <20251022-macb-eyeq5-v2-4-7c140abb0581@bootlin.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 Hi, On 22/10/2025 09:38, Théo Lebrun wrote: > The bp->sgmii_phy field is initialised at probe by init_reset_optional() > if bp->phy_interface == PHY_INTERFACE_MODE_SGMII. It gets used by: > - zynqmp_config: "cdns,zynqmp-gem" or "xlnx,zynqmp-gem" compatibles. > - mpfs_config: "microchip,mpfs-macb" compatible. > - versal_config: "xlnx,versal-gem" compatible. > > Make name more generic as EyeQ5 requires the PHY in SGMII & RGMII cases. > > Drop "for ZynqMP SGMII mode" comment that is already a lie, as it gets > used on Microchip platforms as well. And soon it won't be SGMII-only. > > Signed-off-by: Théo Lebrun Reviewed-by: Maxime Chevallier Thanks Théo, Maxime