From: Jeremy Kerr <jk@codeconstruct.com.au>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Matt Johnston <matt@codeconstruct.com.au>,
stable <stable@kernel.org>
Subject: Re: [PATCH net] net: mctp: usb: properly drop the usb interface on probe error
Date: Tue, 24 Feb 2026 14:31:03 +0800 [thread overview]
Message-ID: <53bc468db1fe156cf949cb1774b701d209935a83.camel@codeconstruct.com.au> (raw)
In-Reply-To: <2026022314-retiring-accustom-ca7b@gregkh>
Hi Greg,
> > > diff --git a/drivers/net/mctp/mctp-usb.c b/drivers/net/mctp/mctp-usb.c
> > > index ef860cfc629f..eef17ae89298 100644
> > > --- a/drivers/net/mctp/mctp-usb.c
> > > +++ b/drivers/net/mctp/mctp-usb.c
> > > @@ -355,6 +355,7 @@ static int mctp_usb_probe(struct usb_interface *intf,
> > > usb_free_urb(dev->tx_urb);
> > > usb_free_urb(dev->rx_urb);
> > > free_netdev(netdev);
> > > + usb_put_dev(dev->usbdev);
> > > return rc;
> > > }
> >
> > Should we not do the usb_put_dev() before the free_netdev()?
>
> Why? The usb_put_dev() doesn't really do anything, except for the fact
> that you have to do it because you did a usb_get_dev() earlier.
More that the dev-> dereference may be invalid at that point, since the
netdev (and hence dev) has been free_netdev()-ed.
Cheers,
Jeremy
next prev parent reply other threads:[~2026-02-24 6:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 11:33 [PATCH net] net: mctp: usb: properly drop the usb interface on probe error Greg Kroah-Hartman
2026-02-24 1:41 ` Jeremy Kerr
2026-02-24 1:50 ` Jeremy Kerr
2026-02-24 6:18 ` Greg Kroah-Hartman
2026-02-24 6:31 ` Jeremy Kerr [this message]
2026-02-25 14:35 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53bc468db1fe156cf949cb1774b701d209935a83.camel@codeconstruct.com.au \
--to=jk@codeconstruct.com.au \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeconstruct.com.au \
--cc=netdev@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox