From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36C5BC10F0E for ; Sun, 7 Apr 2019 20:31:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E5BEE20880 for ; Sun, 7 Apr 2019 20:31:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pBsTM69U" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726461AbfDGUbk (ORCPT ); Sun, 7 Apr 2019 16:31:40 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:36513 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726411AbfDGUbk (ORCPT ); Sun, 7 Apr 2019 16:31:40 -0400 Received: by mail-pg1-f194.google.com with SMTP id 85so6073254pgc.3 for ; Sun, 07 Apr 2019 13:31:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=g1h639oe46Whxmb9PDY5ESJgkXBT6wt2D1BKCyfWRAE=; b=pBsTM69UZ6XwuWP/0do1oI4GRku8yqY/w4quOYqTFIbx1idPTeErD/Y9SheZJZh5r/ WnYQrEDxnUJ2KHsSJyUviolwgs3ieXQn8wPgsTCdVgKocJFgX5mS8xlOULzGod2GyOtc iKEbKQJS6iFYoGesLxMgFKHMOfDTgiaNnmitCd8Ct3BxGKWypU5iofHQu74srCm8usG6 gX7qAY3WV0lGy+AgYDBJVlkI+LpSrmKm2NB1BLINLkqc7Fxj6paKrPc3hNZ/+Q98q/kj zHNdJhWX+HB4GmV4MSnYouqk3hhszu9agBjRNZmJGSaYJsiS0Js+RraSLtIG1urUCNeV xjdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=g1h639oe46Whxmb9PDY5ESJgkXBT6wt2D1BKCyfWRAE=; b=TFfhGBKb7Ws46LkJ+jLRCXIYoUqGMTvWAWpBmYfZlcMF57Ad1tULOfhCk8HgVLYJhL jvzrHjRtxA/2MaWml3Jmw8rOJxy8HZVP2aSTEQ0EMXaT6LUnzlJKLBzWUaE/EIfMbiFV HY4qhyzw1aqNqXOES7EkzC5DHaXrTQQAwODbO177mlzdIx6vTi6xLr0xqUKcAANKwakC iM+VL/ADsdDHnPHEoEUQMf/eUsjX2NESspPEOD4AM3575QhbxO5E7dQ9RG+40d38aE1u YWztRAQVPMUKeQXVHDIMEc+czGsADucvk6uZ8jAuKNHVSSyimE551hBDwPYanYfEIYIQ +RGg== X-Gm-Message-State: APjAAAVm6vAtyPT1EEw2j9BJ63GzSPUxPzaas0Qq8ozrSWSpco1A4+sW eiksg2jhtS97y9IFFI57pCk= X-Google-Smtp-Source: APXvYqw5v1B1rHL9fMlbkyYvEPjDA9AQYyLkRn0gbzP4SrmVAWVB07EvlezH/mC9Z0Onl76kWuPG0w== X-Received: by 2002:aa7:8c42:: with SMTP id e2mr25652550pfd.24.1554669099216; Sun, 07 Apr 2019 13:31:39 -0700 (PDT) Received: from [192.168.1.3] (ip68-101-123-102.oc.oc.cox.net. [68.101.123.102]) by smtp.gmail.com with ESMTPSA id c22sm26764066pfn.136.2019.04.07.13.31.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 07 Apr 2019 13:31:38 -0700 (PDT) Subject: Re: [PATCH net-next] net: phy: switch drivers to use dynamic feature detection To: Heiner Kallweit , Andrew Lunn , David Miller , Ray Jui , Scott Branden , Richard Cochran , Kevin Hilman , Heiko Stuebner Cc: bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-rockchip@lists.infradead.org References: <0cc96fab-e102-c0d1-ade0-90e3e06dc9f1@gmail.com> From: Florian Fainelli Openpgp: preference=signencrypt Message-ID: <53f5d96e-4594-7a32-792d-4837479da7f2@gmail.com> Date: Sun, 7 Apr 2019 13:31:37 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <0cc96fab-e102-c0d1-ade0-90e3e06dc9f1@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 4/7/2019 2:57 AM, Heiner Kallweit wrote: > Recently genphy_read_abilities() has been added that dynamically detects > clause 22 PHY abilities. I *think* this detection should work with all > supported PHY's, at least for the ones with basic features sets, i.e. > PHY_BASIC_FEATURES and PHY_GBIT_FEATURES. So let's remove setting these > features explicitly and rely on phylib feature detection. > > I don't have access to most of these PHY's, therefore I'd appreciate > regression testing. The nice thing about the features is that we can right away tell which PHY entries are Fast Ethernet/Gigabit etc... so if you remove that assignment, we would need at least a standardized comment allowing us to quickly grep for that information. -- Florian