netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Florian Westphal <fw@strlen.de>, e1000-devel@lists.sourceforge.net
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 7/7] e1000: switch to napi_gro_frags api
Date: Sun, 31 Aug 2014 16:03:12 +0400	[thread overview]
Message-ID: <54030F00.3010706@cogentembedded.com> (raw)
In-Reply-To: <1409423307-23470-8-git-send-email-fw@strlen.de>

Hello.

On 8/30/2014 10:28 PM, Florian Westphal wrote:

> napi_gro_frags allows skb re-use in case GRO can merge payload pages
> into an skb on the gro lists.

> netperf TCP_STREAM, kvm-e1000 emulation, mtu 9k:
> Size   Size    Size     Time     Throughput
> bytes  bytes   bytes    secs.    10^6bits/sec
> old: 87380  16384  16384    30.00  8985.78
> new: 87380  16384  16384    30.00  9907.05

> Signed-off-by: Florian Westphal <fw@strlen.de>
> ---
>   drivers/net/ethernet/intel/e1000/e1000_main.c | 50 ++++++++++++++++++---------
>   1 file changed, 33 insertions(+), 17 deletions(-)

> diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/ethernet/intel/e1000/e1000_main.c
> index 9ac9a77..784a67f 100644
> --- a/drivers/net/ethernet/intel/e1000/e1000_main.c
> +++ b/drivers/net/ethernet/intel/e1000/e1000_main.c
[...]
> @@ -4234,7 +4234,23 @@ process_skb:
>   					 * buffer_info->rxbuf.page
>   					 */
>   					skb_put(skb, length);
> +					e1000_rx_checksum(adapter,
> +							  (u32)(status) |
> +							  ((u32)(rx_desc->errors) << 24),

    Inner parens are not needed.

[...]

WBR, Sergei


------------------------------------------------------------------------------
Slashdot TV.  
Video for Nerds.  Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel&#174; Ethernet, visit http://communities.intel.com/community/wired

  reply	other threads:[~2014-08-31 12:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-30 18:28 e1000: convert to build_skb/napi_gro_frags api Florian Westphal
2014-08-30 18:28 ` [PATCH 1/7] e1000: move e1000_tbi_adjust_stats to where its used Florian Westphal
2014-08-30 18:28 ` [PATCH 2/7] e1000: move tbi workaround code into helper function Florian Westphal
2014-08-30 18:28 ` [PATCH 3/7] e1000: perform copybreak ahead of dma unmap Florian Westphal
2014-08-30 18:28 ` [PATCH 4/7] e1000: add and use e1000_rx_buffer info for rx Florian Westphal
2014-08-30 18:28 ` [PATCH 5/7] e1000: rename struct e1000_buffer to e1000_tx_buffer Florian Westphal
2014-08-30 18:28 ` [PATCH 6/7] e1000: convert to build_skb Florian Westphal
2014-08-30 18:28 ` [PATCH 7/7] e1000: switch to napi_gro_frags api Florian Westphal
2014-08-31 12:03   ` Sergei Shtylyov [this message]
2014-09-02  0:30 ` e1000: convert to build_skb/napi_gro_frags api Jeff Kirsher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54030F00.3010706@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=e1000-devel@lists.sourceforge.net \
    --cc=fw@strlen.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).