From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mugunthan V N Subject: Re: [PATCH 2/2] net: ethernet: cpsw: fix interrupt lookup logic in cpsw_probe() Date: Wed, 3 Sep 2014 12:58:54 +0530 Message-ID: <5406C336.3020005@ti.com> References: <1409676245-13897-1-git-send-email-zonque@gmail.com> <1409676245-13897-2-git-send-email-zonque@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Cc: , , To: Daniel Mack , Return-path: Received: from arroyo.ext.ti.com ([192.94.94.40]:37822 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755553AbaICH26 (ORCPT ); Wed, 3 Sep 2014 03:28:58 -0400 In-Reply-To: <1409676245-13897-2-git-send-email-zonque@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tuesday 02 September 2014 10:14 PM, Daniel Mack wrote: > The code in cpsw_probe() currently iterates over the available > interrupt resources and requests each of them. While doing so, it > keeps track of their indices through priv->irqs_table. > > However, the code currently only remembers the last interrupt in > a resource, and will leak the others if there is more than one. > This can only happen for board-file driven platforms and not via DT, > however. > > Also, there is currently no bounds check, while priv->irqs_table is a > fixed-size array. If we are passed more than 4 resources, we're in > trouble. > > This patch introduces a bounds check and changes the way interrupt > indices are kept. Tested on a Beagle Bone Black board only. > > Signed-off-by: Daniel Mack The drivers is not supported for non-DT platforms as all the platforms which uses CPSW are DT only platforms. Regards Mugunthan V N