* [PATCH] drivers/net/fddi/skfp/h/skfbi.h: Remove useless PCI_BASE_2ND macros
@ 2014-09-03 15:26 Chen Gang
2014-09-05 21:52 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Chen Gang @ 2014-09-03 15:26 UTC (permalink / raw)
To: David S. Miller
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
michal.simek, Michal Simek
They are use less, and may generate compiling warnings, so remove them
(microblaze, arc, arm64, and unicore32 have already defined PCI_IOBASE).
The related warnings (with allmodconfig under microblaze):
CC [M] drivers/net/fddi/skfp/skfddi.o
In file included from drivers/net/fddi/skfp/skfddi.c:95:0:
drivers/net/fddi/skfp/h/skfbi.h:151:0: warning: "PCI_IOBASE" redefined
#define PCI_IOBASE 0xffffff00L /* Bit 31..8: I/O Base address */
^
In file included from include/linux/io.h:22:0,
from include/linux/pci.h:31,
from drivers/net/fddi/skfp/skfddi.c:82:
./arch/microblaze/include/asm/io.h:33:0: note: this is the location of the previous definition
#define PCI_IOBASE ((void __iomem *)_IO_BASE)
^
Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
drivers/net/fddi/skfp/h/skfbi.h | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/net/fddi/skfp/h/skfbi.h b/drivers/net/fddi/skfp/h/skfbi.h
index c1ba26c..3de2f0d 100644
--- a/drivers/net/fddi/skfp/h/skfbi.h
+++ b/drivers/net/fddi/skfp/h/skfbi.h
@@ -147,11 +147,6 @@
#define PCI_MEM64BIT (2<<1) /* Base addr anywhere in 64 Bit range */
#define PCI_MEMSPACE 0x00000001L /* Bit 0: Memory Space Indic. */
-/* PCI_BASE_2ND 32 bit 2nd Base address */
-#define PCI_IOBASE 0xffffff00L /* Bit 31..8: I/O Base address */
-#define PCI_IOSIZE 0x000000fcL /* Bit 7..2: I/O Size Requirements */
-#define PCI_IOSPACE 0x00000001L /* Bit 0: I/O Space Indicator */
-
/* PCI_SUB_VID 16 bit Subsystem Vendor ID */
/* PCI_SUB_ID 16 bit Subsystem ID */
--
1.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers/net/fddi/skfp/h/skfbi.h: Remove useless PCI_BASE_2ND macros
2014-09-03 15:26 [PATCH] drivers/net/fddi/skfp/h/skfbi.h: Remove useless PCI_BASE_2ND macros Chen Gang
@ 2014-09-05 21:52 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-09-05 21:52 UTC (permalink / raw)
To: gang.chen.5i5j; +Cc: netdev, linux-kernel, michal.simek, monstr
From: Chen Gang <gang.chen.5i5j@gmail.com>
Date: Wed, 03 Sep 2014 23:26:26 +0800
> They are use less, and may generate compiling warnings, so remove them
> (microblaze, arc, arm64, and unicore32 have already defined PCI_IOBASE).
>
> The related warnings (with allmodconfig under microblaze):
>
> CC [M] drivers/net/fddi/skfp/skfddi.o
> In file included from drivers/net/fddi/skfp/skfddi.c:95:0:
> drivers/net/fddi/skfp/h/skfbi.h:151:0: warning: "PCI_IOBASE" redefined
> #define PCI_IOBASE 0xffffff00L /* Bit 31..8: I/O Base address */
> ^
> In file included from include/linux/io.h:22:0,
> from include/linux/pci.h:31,
> from drivers/net/fddi/skfp/skfddi.c:82:
> ./arch/microblaze/include/asm/io.h:33:0: note: this is the location of the previous definition
> #define PCI_IOBASE ((void __iomem *)_IO_BASE)
> ^
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-05 21:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-03 15:26 [PATCH] drivers/net/fddi/skfp/h/skfbi.h: Remove useless PCI_BASE_2ND macros Chen Gang
2014-09-05 21:52 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).