From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felix Fietkau Subject: Re: [patch net-next 07/13] dsa: implement ndo_swdev_get_id Date: Fri, 05 Sep 2014 06:43:23 +0200 Message-ID: <54093F6B.7080507@openwrt.org> References: <1409736300-12303-1-git-send-email-jiri@resnulli.us> <1409736300-12303-8-git-send-email-jiri@resnulli.us> <5407A25A.8050401@gmail.com> <20140904124701.GH1867@nanopsycho.lan> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: ryazanov.s.a-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, jasowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, john.r.fastabend-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, Neil.Jerram-QnUH15yq9NYqDJ6do+/SaQ@public.gmane.org, edumazet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, andy-QlMahl40kYEqcZcGjlUOXw@public.gmane.org, dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org, ronye-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, jeffrey.t.kirsher-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, ben-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org, buytenh-OLH4Qvv75CYX/NnBR394Jw@public.gmane.org, roopa-qUQiAmfTcIp+XZJcv9eMoEEOCMrvLtNR@public.gmane.org, jhs-jkUAjuhPggJWk0Htik3J/w@public.gmane.org, aviadr-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, nicolas.dichtel-pdR9zngts4EAvxtiuMwx3w@public.gmane.org, vyasevic-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org, dborkman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org To: Jiri Pirko , Florian Fainelli Return-path: In-Reply-To: <20140904124701.GH1867-6KJVSR23iU5sFDB2n11ItA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-yBygre7rU0TnMu66kgdUjQ@public.gmane.org Sender: "dev" List-Id: netdev.vger.kernel.org On 2014-09-04 14:47, Jiri Pirko wrote: > Thu, Sep 04, 2014 at 01:20:58AM CEST, f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote: >>On 09/03/2014 02:24 AM, Jiri Pirko wrote: >>> Signed-off-by: Jiri Pirko >>> --- >>> include/linux/netdevice.h | 3 ++- >>> include/net/dsa.h | 1 + >>> net/dsa/Kconfig | 2 +- >>> net/dsa/dsa.c | 3 +++ >>> net/dsa/slave.c | 10 ++++++++++ >>> 5 files changed, 17 insertions(+), 2 deletions(-) >>> >>> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h >>> index 6a009d1..7ee070f 100644 >>> --- a/include/linux/netdevice.h >>> +++ b/include/linux/netdevice.h >>> @@ -41,7 +41,6 @@ >>> >>> #include >>> #include >>> -#include >>> #ifdef CONFIG_DCB >>> #include >>> #endif >>> @@ -1259,6 +1258,8 @@ enum netdev_priv_flags { >>> #define IFF_LIVE_ADDR_CHANGE IFF_LIVE_ADDR_CHANGE >>> #define IFF_MACVLAN IFF_MACVLAN >>> >>> +#include >>> + >>> /** >>> * struct net_device - The DEVICE structure. >>> * Actually, this whole structure is a big mistake. It mixes I/O >>> diff --git a/include/net/dsa.h b/include/net/dsa.h >>> index 9771292..d60cd42 100644 >>> --- a/include/net/dsa.h >>> +++ b/include/net/dsa.h >>> @@ -140,6 +140,7 @@ struct dsa_switch { >>> u32 phys_mii_mask; >>> struct mii_bus *slave_mii_bus; >>> struct net_device *ports[DSA_MAX_PORTS]; >>> + struct netdev_phys_item_id psid; >>> }; >>> >>> static inline bool dsa_is_cpu_port(struct dsa_switch *ds, int p) >>> diff --git a/net/dsa/Kconfig b/net/dsa/Kconfig >>> index a585fd6..4e144a2 100644 >>> --- a/net/dsa/Kconfig >>> +++ b/net/dsa/Kconfig >>> @@ -1,6 +1,6 @@ >>> config HAVE_NET_DSA >>> def_bool y >>> - depends on NETDEVICES && !S390 >>> + depends on NETDEVICES && NET_SWITCHDEV && !S390 >> >>It does not look like this is necessary, we are only using definitions >>from net/dsa.h and include/linux/netdevice.h, and if it was, a 'select' >>would be more appropriate here I think. >> >>TBH, I think we should rather drop this patch for now, I do not see any >>benefit in providing a random id over no-id at all. > > Well, the benefit is that you are still able to see which ports belong > to the same switch. I think it's a bad idea to force switchdev bloat onto DSA users just for that random id thing. - Felix