netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] bonding: limit primary_reselect to modes that use primary only
@ 2014-09-05 12:13 Nikolay Aleksandrov
  2014-09-05 12:17 ` Nikolay Aleksandrov
  0 siblings, 1 reply; 2+ messages in thread
From: Nikolay Aleksandrov @ 2014-09-05 12:13 UTC (permalink / raw)
  To: netdev; +Cc: vfalico, j.vosburgh, andy, davem, Nikolay Aleksandrov

Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com>
---
 drivers/net/bonding/bond_options.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/bonding/bond_options.c b/drivers/net/bonding/bond_options.c
index d8dc17faa6b4..591c1fbb7c8d 100644
--- a/drivers/net/bonding/bond_options.c
+++ b/drivers/net/bonding/bond_options.c
@@ -316,6 +316,9 @@ static const struct bond_option bond_opts[] = {
 		.id = BOND_OPT_PRIMARY_RESELECT,
 		.name = "primary_reselect",
 		.desc = "Reselect primary slave once it comes up",
+		.unsuppmodes = BOND_MODE_ALL_EX(BIT(BOND_MODE_ACTIVEBACKUP) |
+						BIT(BOND_MODE_TLB) |
+						BIT(BOND_MODE_ALB)),
 		.values = bond_primary_reselect_tbl,
 		.set = bond_option_primary_reselect_set
 	},
-- 
1.9.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next] bonding: limit primary_reselect to modes that use primary only
  2014-09-05 12:13 [PATCH net-next] bonding: limit primary_reselect to modes that use primary only Nikolay Aleksandrov
@ 2014-09-05 12:17 ` Nikolay Aleksandrov
  0 siblings, 0 replies; 2+ messages in thread
From: Nikolay Aleksandrov @ 2014-09-05 12:17 UTC (permalink / raw)
  To: netdev; +Cc: vfalico, j.vosburgh, andy, davem

On 05/09/14 14:13, Nikolay Aleksandrov wrote:
> Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com>
> ---
>   drivers/net/bonding/bond_options.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/bonding/bond_options.c b/drivers/net/bonding/bond_options.c
> index d8dc17faa6b4..591c1fbb7c8d 100644
> --- a/drivers/net/bonding/bond_options.c
> +++ b/drivers/net/bonding/bond_options.c
> @@ -316,6 +316,9 @@ static const struct bond_option bond_opts[] = {
>   		.id = BOND_OPT_PRIMARY_RESELECT,
>   		.name = "primary_reselect",
>   		.desc = "Reselect primary slave once it comes up",
> +		.unsuppmodes = BOND_MODE_ALL_EX(BIT(BOND_MODE_ACTIVEBACKUP) |
> +						BIT(BOND_MODE_TLB) |
> +						BIT(BOND_MODE_ALB)),
>   		.values = bond_primary_reselect_tbl,
>   		.set = bond_option_primary_reselect_set
>   	},
>

Actually, self-nak as this adds option dependency.
Sorry for the noise

Nik

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-09-05 12:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-05 12:13 [PATCH net-next] bonding: limit primary_reselect to modes that use primary only Nikolay Aleksandrov
2014-09-05 12:17 ` Nikolay Aleksandrov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).