* [PATCH] irda: vlsi_ir: use %*ph specifier
@ 2014-09-05 14:37 Andy Shevchenko
2014-09-05 17:21 ` Sergei Shtylyov
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2014-09-05 14:37 UTC (permalink / raw)
To: Samuel Ortiz, netdev; +Cc: Andy Shevchenko
Instead of looping in the code let's use kernel extension to dump small
buffers.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/net/irda/vlsi_ir.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/net/irda/vlsi_ir.c b/drivers/net/irda/vlsi_ir.c
index a04af9d..0319eba 100644
--- a/drivers/net/irda/vlsi_ir.c
+++ b/drivers/net/irda/vlsi_ir.c
@@ -323,14 +323,9 @@ static void vlsi_proc_ring(struct seq_file *seq, struct vlsi_ring *r)
j = (unsigned) rd_get_count(rd);
seq_printf(seq, "current: rd = %d / status = %02x / len = %u\n",
h, (unsigned)rd_get_status(rd), j);
- if (j > 0) {
- seq_printf(seq, " data:");
- if (j > 20)
- j = 20;
- for (i = 0; i < j; i++)
- seq_printf(seq, " %02x", (unsigned)((unsigned char *)rd->buf)[i]);
- seq_printf(seq, "\n");
- }
+ if (j > 0)
+ seq_printf(seq, " data: %*ph\n", j > 20 ? 20 : j,
+ rd->buf);
}
for (i = 0; i < r->size; i++) {
rd = &r->rd[i];
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] irda: vlsi_ir: use %*ph specifier
2014-09-05 14:37 [PATCH] irda: vlsi_ir: use %*ph specifier Andy Shevchenko
@ 2014-09-05 17:21 ` Sergei Shtylyov
2014-09-07 23:09 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Sergei Shtylyov @ 2014-09-05 17:21 UTC (permalink / raw)
To: Andy Shevchenko, Samuel Ortiz, netdev
Hello.
On 09/05/2014 06:37 PM, Andy Shevchenko wrote:
> Instead of looping in the code let's use kernel extension to dump small
> buffers.
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/net/irda/vlsi_ir.c | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)
> diff --git a/drivers/net/irda/vlsi_ir.c b/drivers/net/irda/vlsi_ir.c
> index a04af9d..0319eba 100644
> --- a/drivers/net/irda/vlsi_ir.c
> +++ b/drivers/net/irda/vlsi_ir.c
> @@ -323,14 +323,9 @@ static void vlsi_proc_ring(struct seq_file *seq, struct vlsi_ring *r)
> j = (unsigned) rd_get_count(rd);
> seq_printf(seq, "current: rd = %d / status = %02x / len = %u\n",
> h, (unsigned)rd_get_status(rd), j);
> - if (j > 0) {
> - seq_printf(seq, " data:");
> - if (j > 20)
> - j = 20;
> - for (i = 0; i < j; i++)
> - seq_printf(seq, " %02x", (unsigned)((unsigned char *)rd->buf)[i]);
> - seq_printf(seq, "\n");
> - }
> + if (j > 0)
> + seq_printf(seq, " data: %*ph\n", j > 20 ? 20 : j,
Why not min(j, 20)?
> + rd->buf);
> }
WBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] irda: vlsi_ir: use %*ph specifier
2014-09-05 17:21 ` Sergei Shtylyov
@ 2014-09-07 23:09 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2014-09-07 23:09 UTC (permalink / raw)
To: sergei.shtylyov; +Cc: andriy.shevchenko, samuel, netdev
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Fri, 05 Sep 2014 21:21:08 +0400
> On 09/05/2014 06:37 PM, Andy Shevchenko wrote:
>
>> + seq_printf(seq, " data: %*ph\n", j > 20 ? 20 : j,
>
> Why not min(j, 20)?
Agreed.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-07 23:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-05 14:37 [PATCH] irda: vlsi_ir: use %*ph specifier Andy Shevchenko
2014-09-05 17:21 ` Sergei Shtylyov
2014-09-07 23:09 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).