Compilation error on freshly pulled net-next?

Compilation error on freshly pulled net-next?

[Rick Jones]

I was going to do some additional "floor sweeping" and put 
dev_consume_skb_any() into another driver or two, so I did a fresh pull 
of net-next and a make and got:

   CC      net/core/rtnetlink.o
net/core/rtnetlink.c: In function ‘if_nlmsg_size’:
net/core/rtnetlink.c:868:84: error: expected ‘;’ before ‘J’
net/core/rtnetlink.c: At top level:
net/core/rtnetlink.c:420:15: warning: ‘rtnl_link_get_size’ defined but 
not used [-Wunused-function]
net/core/rtnetlink.c:497:15: warning: ‘rtnl_link_get_af_size’ defined 
but not used [-Wunused-function]


Looks like someone slipped a J in there and confused things:

                + rtnl_port_size(dev, ext_filter_mask) /* IFLA_VF_PORTS 
+ IFLA_PORT_SELF */J            + rtnl_link_get_size(dev) /* 
IFLA_LINKINFO */
                + rtnl_link_get_af_size(dev) /* IFLA_AF_SPEC */

(hopefully my mail client won't have mangled things too badly)

What is odd though is a git diff after I've replaced that 'J' with a 
return isn't giving me any output.

rick jones

Re: Compilation error on freshly pulled net-next?

[David Miller]

From: Rick Jones <rick.jones2@hp.com>
Date: Fri, 05 Sep 2014 14:47:43 -0700

> Looks like someone slipped a J in there and confused things:
> 
>                + rtnl_port_size(dev, ext_filter_mask) /* IFLA_VF_PORTS +
>                IFLA_PORT_SELF */J + rtnl_link_get_size(dev) /* IFLA_LINKINFO */
>                + rtnl_link_get_af_size(dev) /* IFLA_AF_SPEC */
> 
> (hopefully my mail client won't have mangled things too badly)
> 
> What is odd though is a git diff after I've replaced that 'J' with a
> return isn't giving me any output.

That doesn't exist in my tree.

Re: Compilation error on freshly pulled net-next?

[Rick Jones]

On 09/05/2014 03:09 PM, David Miller wrote:
> From: Rick Jones <rick.jones2@hp.com>
> Date: Fri, 05 Sep 2014 14:47:43 -0700
>
>> Looks like someone slipped a J in there and confused things:
>>
>>                 + rtnl_port_size(dev, ext_filter_mask) /* IFLA_VF_PORTS +
>>                 IFLA_PORT_SELF */J + rtnl_link_get_size(dev) /* IFLA_LINKINFO */
>>                 + rtnl_link_get_af_size(dev) /* IFLA_AF_SPEC */
>>
>> (hopefully my mail client won't have mangled things too badly)
>>
>> What is odd though is a git diff after I've replaced that 'J' with a
>> return isn't giving me any output.
>
> That doesn't exist in my tree.

That's good.  Must have been some sort of glitch at my end, but what it 
could have been I've no clue.  I guess I'll just chalk it up to gremlins 
and see about doing a little light floor sweeping then.

rick

Re: Compilation error on freshly pulled net-next?

[Rustad, Mark D]

[-- Attachment #1: Type: text/plain, Size: 870 bytes --]

On Sep 5, 2014, at 3:09 PM, David Miller <davem@davemloft.net> wrote:

> From: Rick Jones <rick.jones2@hp.com>
> Date: Fri, 05 Sep 2014 14:47:43 -0700
> 
>> Looks like someone slipped a J in there and confused things:
>> 
>>               + rtnl_port_size(dev, ext_filter_mask) /* IFLA_VF_PORTS +
>>               IFLA_PORT_SELF */J + rtnl_link_get_size(dev) /* IFLA_LINKINFO */
>>               + rtnl_link_get_af_size(dev) /* IFLA_AF_SPEC */
>> 
>> (hopefully my mail client won't have mangled things too badly)
>> 
>> What is odd though is a git diff after I've replaced that 'J' with a
>> return isn't giving me any output.
> 
> That doesn't exist in my tree.

Looks like data corruption to me. There is a one-bit difference between line-feed and J. Oh for more ECC-capable systems...

-- 
Mark Rustad, Networking Division, Intel Corporation


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 841 bytes --]