From: Alexander Duyck <alexander.h.duyck@intel.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <eric.dumazet@gmail.com>,
jeffrey.t.kirsher@intel.com
Subject: Re: [PATCH net-next 1/3] net: Add function for parsing the header length out of linear ethernet frames
Date: Fri, 05 Sep 2014 16:15:10 -0700 [thread overview]
Message-ID: <540A43FE.7050708@intel.com> (raw)
In-Reply-To: <CAADnVQKNoOdSuuQ-voKVNpke-4BjvC_pU=g65=m70Y4TsTpTag@mail.gmail.com>
On 09/05/2014 01:02 PM, Alexei Starovoitov wrote:
> On Fri, Sep 5, 2014 at 11:10 AM, Alexander Duyck
> <alexander.h.duyck@intel.com> wrote:
>> This patch updates some of the flow_dissector api so that it can be used to
>> parse the length of ethernet buffers stored in fragments. Most of the
>> changes needed were to __skb_get_poff as it needed to be updated to support
>> sending a linear buffer instead of a skb.
>>
>>
>> u32 __skb_get_poff(const struct sk_buff *skb);
>> +u32 ___skb_get_poff(const struct sk_buff *skb, void *data,
>> + const struct flow_keys *keys, int hlen);
>
> three underscores and not a static function?
> May be we need to come with a proper name for it.
> Two easy to confuse with two underscore version...
Actually what I could do is probably rename the 2 underscore version to
drop the underscores and then rename the 3 underscore version to just 2
underscores. Then it would match up closer with how the other functions
are dealing with the data/hlen values.
Thanks,
Alex
next prev parent reply other threads:[~2014-09-05 23:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 18:09 [PATCH net-next 0/3] Drop get_headlen functions in favor of generic funciton Alexander Duyck
2014-09-05 18:10 ` [PATCH net-next 1/3] net: Add function for parsing the header length out of linear ethernet frames Alexander Duyck
2014-09-05 20:02 ` Alexei Starovoitov
2014-09-05 23:15 ` Alexander Duyck [this message]
2014-09-05 18:11 ` [PATCH net-next 2/3] igb: use new eth_get_headlen interface Alexander Duyck
2014-09-05 18:11 ` [PATCH net-next 3/3] ixgbe: " Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540A43FE.7050708@intel.com \
--to=alexander.h.duyck@intel.com \
--cc=alexei.starovoitov@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).