From: Jaroslav Kysela <perex@perex.cz>
To: Rick Jones <raj@tardy.usa.hp.com>, netdev@vger.kernel.org
Cc: davem@davemloft.net
Subject: Re: [PATCH net-next] hp100: Convert the normal skb free path to dev_consume_skb_any()
Date: Mon, 08 Sep 2014 21:38:57 +0200 [thread overview]
Message-ID: <540E05D1.4000802@perex.cz> (raw)
In-Reply-To: <20140908153133.103882900309@tardy>
Date 8.9.2014 17:31, Rick Jones wrote:
> From: Rick Jones <rick.jones2@hp.com>
>
> A bit of floor sweeping in a dusty old corner. Convert the "normal"
> skb free calls to dev_consume_skb_any() so packet drop tracing will
> be more sane.
>
> Signed-off-by: Rick Jones <rick.jones2@hp.com>
Acked-by: Jaroslav Kysela <perex@perex.cz>
>
> ---
>
> Compile tested only. I wonder how many of these cards are still in
> operation?-)
It's really old hw..
>
> diff --git a/drivers/net/ethernet/hp/hp100.c b/drivers/net/ethernet/hp/hp100.c
> index ed7916f..76a6e0c 100644
> --- a/drivers/net/ethernet/hp/hp100.c
> +++ b/drivers/net/ethernet/hp/hp100.c
> @@ -1627,7 +1627,7 @@ static void hp100_clean_txring(struct net_device *dev)
> #endif
> /* Conversion to new PCI API : NOP */
> pci_unmap_single(lp->pci_dev, (dma_addr_t) lp->txrhead->pdl[1], lp->txrhead->pdl[2], PCI_DMA_TODEVICE);
> - dev_kfree_skb_any(lp->txrhead->skb);
> + dev_consume_skb_any(lp->txrhead->skb);
> lp->txrhead->skb = NULL;
> lp->txrhead = lp->txrhead->next;
> lp->txrcommit--;
> @@ -1745,7 +1745,7 @@ static netdev_tx_t hp100_start_xmit(struct sk_buff *skb,
> hp100_ints_on();
> spin_unlock_irqrestore(&lp->lock, flags);
>
> - dev_kfree_skb_any(skb);
> + dev_consume_skb_any(skb);
>
> #ifdef HP100_DEBUG_TX
> printk("hp100: %s: start_xmit: end\n", dev->name);
>
--
Jaroslav Kysela <perex@perex.cz>
Linux Kernel Sound Maintainer
ALSA Project; Red Hat, Inc.
next prev parent reply other threads:[~2014-09-08 19:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-08 15:31 [PATCH net-next] hp100: Convert the normal skb free path to dev_consume_skb_any() Rick Jones
2014-09-08 19:38 ` Jaroslav Kysela [this message]
2014-09-08 22:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540E05D1.4000802@perex.cz \
--to=perex@perex.cz \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=raj@tardy.usa.hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).