netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Anish Bhatt <anish@chelsio.com>,
	Michael Chan <mchan@broadcom.com>,
	"eddie.wai@broadcom.com" <eddie.wai@broadcom.com>
Cc: Jim Davis <jim.epost@gmail.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next <linux-next@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	netdev <netdev@vger.kernel.org>,
	James Bottomley <jbottomley@parallels.com>
Subject: Re: randconfig build error with next-20140909, in drivers/net/ethernet/broadcom/cnic.c
Date: Tue, 09 Sep 2014 15:56:02 -0700	[thread overview]
Message-ID: <540F8582.50703@infradead.org> (raw)
In-Reply-To: <525DB349B3FB5444AE057A887CB2A8D88E3CEC@nice.asicdesigners.com>

On 09/09/14 14:08, Anish Bhatt wrote:
> 
>> Adding depends on IPV6 || IPV6=n doesn't work for SCSI_BNX2X_FCOE, but
>> works for SCSI_BNX2_ISCSI?
> 
> It fixes the config issue for both, but with FCOE; make scripts will complain about recursive dependencies with the following :
> 
> scripts/kconfig/conf --silentoldconfig Kconfig
> net/Kconfig:5:error: recursive dependency detected!
> net/Kconfig:5:  symbol NET is selected by SCSI_NETLINK
> drivers/scsi/Kconfig:43:        symbol SCSI_NETLINK is selected by SCSI_FC_ATTRS
> drivers/scsi/Kconfig:258:       symbol SCSI_FC_ATTRS is selected by LIBFC
> drivers/scsi/Kconfig:586:       symbol LIBFC is selected by SCSI_BNX2X_FCOE
> drivers/scsi/bnx2fc/Kconfig:1:  symbol SCSI_BNX2X_FCOE depends on IPV6
> net/ipv6/Kconfig:6:     symbol IPV6 depends on NET

It would be really good if SCSI_NETLINK depended on NET instead of selected NET.
We shouldn't have kconfig symbols that use 'select' on entire subsystems.

-- 
~Randy

  reply	other threads:[~2014-09-09 22:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-09 14:38 randconfig build error with next-20140909, in drivers/net/ethernet/broadcom/cnic.c Jim Davis
2014-09-09 20:24 ` Anish Bhatt
2014-09-09 20:47   ` Michael Chan
2014-09-09 21:08     ` Anish Bhatt
2014-09-09 22:56       ` Randy Dunlap [this message]
2014-09-09 23:16         ` Anish Bhatt
2014-09-09 23:20           ` Michael Chan
2014-09-09 23:36             ` Anish Bhatt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=540F8582.50703@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=anish@chelsio.com \
    --cc=davem@davemloft.net \
    --cc=eddie.wai@broadcom.com \
    --cc=jbottomley@parallels.com \
    --cc=jim.epost@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=mchan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).