From: Florian Fainelli <f.fainelli@gmail.com>
To: Alexander Duyck <alexander.duyck@gmail.com>, netdev@vger.kernel.org
Cc: davem@davemloft.net, kernel@wantstofly.org
Subject: Re: [PATCH] netdevice: Support DSA tagging when DSA is built as a module
Date: Sat, 13 Sep 2014 03:06:02 -0700 [thread overview]
Message-ID: <5414170A.4080907@gmail.com> (raw)
In-Reply-To: <20140913015950.26705.51106.stgit@ahduyck-workstation.home>
Le 12/09/2014 18:59, Alexander Duyck a écrit :
> This change corrects an error seen when DSA tagging is built as a module.
> Without this change it is not possible to get XDSA tagged frames as the
> test for tagging is stripped by the #ifdef check.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> include/linux/netdevice.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index ba72f6b..c8f3806 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -1789,7 +1789,7 @@ void dev_net_set(struct net_device *dev, struct net *net)
>
> static inline bool netdev_uses_dsa(struct net_device *dev)
> {
> -#ifdef CONFIG_NET_DSA
> +#if IS_ENABLED(CONFIG_NET_DSA)
> if (dev->dsa_ptr != NULL)
> return dsa_uses_tagged_protocol(dev->dsa_ptr);
> #endif
>
prev parent reply other threads:[~2014-09-13 3:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-13 1:59 [PATCH] netdevice: Support DSA tagging when DSA is built as a module Alexander Duyck
2014-09-13 10:06 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5414170A.4080907@gmail.com \
--to=f.fainelli@gmail.com \
--cc=alexander.duyck@gmail.com \
--cc=davem@davemloft.net \
--cc=kernel@wantstofly.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).