From: John Fastabend <john.r.fastabend@intel.com>
To: John Fastabend <john.fastabend@gmail.com>, netdev@vger.kernel.org
Subject: Re: [RFC PATCH] net: sched: fix unsued cpu variable
Date: Sat, 13 Sep 2014 11:25:15 -0700 [thread overview]
Message-ID: <54148C0B.8040500@intel.com> (raw)
In-Reply-To: <20140913181352.32293.58637.stgit@nitbit.x32>
On 09/13/2014 11:13 AM, John Fastabend wrote:
> kbuild test robot reported an unused variable cpu in cls_u32.c
> after the patch below. This happens when PERF and MARK config
> variables are disabled
>
> commit 459d5f626da75573e985a7197b0919c3b143146c
> Author: John Fastabend <john.fastabend@gmail.com>
> Date: Fri Sep 12 20:08:47 2014 -0700
>
> net: sched: make cls_u32 per cpu
>
> One way to fix this is to use separate variables for perf
> and mark and define the cpu variable inside the ifdef
> logic.
>
> I don't really like this though so I'm wondering if I can
> clean up the ifdef/endif logic to make this easier to read.
> So RFC patch until I convince myself there isn't a better
> way. Thought it might be worth sending out in case someone
> else has an idea.
>
> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
kbuild robot kicked me another warning I missed I'll send out
a couple patches tonight or tomorrow morning to resolve them.
Thanks,
John
prev parent reply other threads:[~2014-09-13 18:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-13 18:13 [RFC PATCH] net: sched: fix unsued cpu variable John Fastabend
2014-09-13 18:25 ` John Fastabend [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54148C0B.8040500@intel.com \
--to=john.r.fastabend@intel.com \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).