From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: David L Stevens <david.stevens@oracle.com>,
David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/3] sunvnet: allow admin to set sunvnet MTU
Date: Sat, 13 Sep 2014 23:17:55 +0300 [thread overview]
Message-ID: <5414A673.4090300@cogentembedded.com> (raw)
In-Reply-To: <54137231.3050304@oracle.com>
Hello.
On 9/13/2014 1:22 AM, David L Stevens wrote:
> This patch allows an admin to set the MTU on a sunvnet device to arbitrary
> values between the minimum (68) and maximum (65535) IPv4 packet sizes.
> Signed-off-by: David L Stevens <david.stevens@oracle.com>
> ---
> drivers/net/ethernet/sun/sunvnet.c | 6 +++++-
> drivers/net/ethernet/sun/sunvnet.h | 2 +-
> 2 files changed, 6 insertions(+), 2 deletions(-)
> diff --git a/drivers/net/ethernet/sun/sunvnet.c b/drivers/net/ethernet/sun/sunvnet.c
> index a6418bb..b557ec4 100644
> --- a/drivers/net/ethernet/sun/sunvnet.c
> +++ b/drivers/net/ethernet/sun/sunvnet.c
> @@ -751,6 +751,10 @@ static int vnet_start_xmit(struct sk_buff *skb, struct net_device *dev)
> if (unlikely(!port))
> goto out_dropped;
> + if (skb->len > port->vio.rmtu) {
The patch seems somehow spoiled -- there should be no space before +.
> + goto out_dropped;
> + }
> +
> spin_lock_irqsave(&port->vio.lock, flags);
> dr = &port->vio.drings[VIO_DRIVER_TX_RING];
WBR, Sergei
prev parent reply other threads:[~2014-09-13 20:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 22:22 [PATCH net-next 2/3] sunvnet: allow admin to set sunvnet MTU David L Stevens
2014-09-13 20:17 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5414A673.4090300@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=david.stevens@oracle.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).