From: Randy Dunlap <rdunlap@infradead.org>
To: Anish Bhatt <anish@chelsio.com>,
netdev@vger.kernel.org, JBottomley@parallels.com,
David Miller <davem@davemloft.net>
Cc: linux-scsi@vger.kernel.org, mchan@broadcom.com,
eddie.wai@broadcom.com, jim.epost@gmail.com
Subject: [PATCH 3] scsi: fix build errors, SCSI_FC_ATTRS needs to depend on SCSI && NET
Date: Mon, 15 Sep 2014 17:20:42 -0700 [thread overview]
Message-ID: <5417825A.4050902@infradead.org> (raw)
In-Reply-To: <1410813921-24400-2-git-send-email-anish@chelsio.com>
From: Randy Dunlap <rdunlap@infradead.org>
Fix build errors when CONFIG_SCSI_NETLINK is enabled but
CONFIG_NET is not enabled:
drivers/built-in.o: In function `scsi_nl_rcv_msg':
scsi_netlink.c:(.text+0x1850fa): undefined reference to `netlink_ack'
scsi_netlink.c:(.text+0x185105): undefined reference to `skb_pull'
scsi_netlink.c:(.text+0x18515d): undefined reference to `netlink_capable'
drivers/built-in.o: In function `scsi_netlink_init':
(.text+0x185244): undefined reference to `init_net'
drivers/built-in.o: In function `scsi_netlink_init':
(.text+0x185258): undefined reference to `__netlink_kernel_create'
drivers/built-in.o: In function `scsi_netlink_exit':
(.text+0x185291): undefined reference to `netlink_kernel_release'
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
drivers/scsi/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Based on Anish's previous SCSI_NETLINK patch.
Sorry about missing this one.
--- lnx-317-rc5.orig/drivers/scsi/Kconfig
+++ lnx-317-rc5/drivers/scsi/Kconfig
@@ -257,7 +257,7 @@ config SCSI_SPI_ATTRS
config SCSI_FC_ATTRS
tristate "FiberChannel Transport Attributes"
- depends on SCSI
+ depends on SCSI && NET
select SCSI_NETLINK
help
If you wish to export transport-specific information about
next prev parent reply other threads:[~2014-09-16 0:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 20:45 [PATCH net 0/2] Fix randconfig errros in bnx2i/bnx2fc caused by IPV6 Anish Bhatt
2014-09-15 20:45 ` [PATCH net 1/2] scsi_netlink : Make SCSI_NETLINK dependent on NET instead of selecting NET Anish Bhatt
2014-09-16 0:20 ` Randy Dunlap [this message]
2014-09-16 3:00 ` [PATCH 3] scsi: fix build errors, SCSI_FC_ATTRS needs to depend on SCSI && NET Anish Bhatt
2014-09-16 3:17 ` Randy Dunlap
2014-09-16 4:11 ` Anish Bhatt
2014-09-16 4:07 ` David Miller
2014-09-15 20:45 ` [PATCH net 2/2] bnx2i/bnx2fc : fix randconfig error in next-20140909 Anish Bhatt
2014-09-15 21:45 ` [PATCH net 0/2] Fix randconfig errros in bnx2i/bnx2fc caused by IPV6 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5417825A.4050902@infradead.org \
--to=rdunlap@infradead.org \
--cc=JBottomley@parallels.com \
--cc=anish@chelsio.com \
--cc=davem@davemloft.net \
--cc=eddie.wai@broadcom.com \
--cc=jim.epost@gmail.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).