* tg3 issue with tcp checksums and vlan packets
@ 2014-09-16 16:43 Vlad Yasevich
2014-09-16 16:54 ` Michael Chan
0 siblings, 1 reply; 3+ messages in thread
From: Vlad Yasevich @ 2014-09-16 16:43 UTC (permalink / raw)
To: Prashant Sreedharan, Michael Chan; +Cc: netdev@vger.kernel.org
Prashant and Michael
I am seeing a strange issue with tg3 driver when I try to pass to it tcp packets
that have partial checksums and inline (non-accelerated) vlan header.
Looking at the packet at the receiver, it appears as if the tcp checksum is never
updated. If I strip the vlan header and set vlan_tci, then everything works ok.
You can easily reproduce this by configuring 802.1ad vlans on top of tg3 device.
This will force software tagging, tg3 will not fix checksums and tcp connections
will not be established.
I've looked at tg3 driver and it doesn't look like it tries to pass any checksum
offsets to the nic/firmware. So it looks like a possible firmware issue.
Can you please take a look.
Thanks
-vlad
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: tg3 issue with tcp checksums and vlan packets
2014-09-16 16:43 tg3 issue with tcp checksums and vlan packets Vlad Yasevich
@ 2014-09-16 16:54 ` Michael Chan
2014-09-16 18:45 ` Vlad Yasevich
0 siblings, 1 reply; 3+ messages in thread
From: Michael Chan @ 2014-09-16 16:54 UTC (permalink / raw)
To: Vlad Yasevich; +Cc: Prashant Sreedharan, netdev@vger.kernel.org
On Tue, 2014-09-16 at 12:43 -0400, Vlad Yasevich wrote:
> Prashant and Michael
>
> I am seeing a strange issue with tg3 driver when I try to pass to it tcp packets
> that have partial checksums and inline (non-accelerated) vlan header.
>
Are you disabling NETIF_F_HW_VLAN_CTAG_TX? I believe TX checksum and
TSO won't work. We need to add some code to disable both when VLAN
acceleration is disabled.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: tg3 issue with tcp checksums and vlan packets
2014-09-16 16:54 ` Michael Chan
@ 2014-09-16 18:45 ` Vlad Yasevich
0 siblings, 0 replies; 3+ messages in thread
From: Vlad Yasevich @ 2014-09-16 18:45 UTC (permalink / raw)
To: Michael Chan; +Cc: Prashant Sreedharan, netdev@vger.kernel.org
On 09/16/2014 12:54 PM, Michael Chan wrote:
> On Tue, 2014-09-16 at 12:43 -0400, Vlad Yasevich wrote:
>> Prashant and Michael
>>
>> I am seeing a strange issue with tg3 driver when I try to pass to it tcp packets
>> that have partial checksums and inline (non-accelerated) vlan header.
>>
>
> Are you disabling NETIF_F_HW_VLAN_CTAG_TX? I believe TX checksum and
> TSO won't work. We need to add some code to disable both when VLAN
> acceleration is disabled.
>
>
No, in this case, I am simply creating an 802.1ad vlan on top. Since
tg3 doesn't provide ETIF_F_HW_VLAN_STAG_TX, we follow the non-accelerated
path.
Currently the driver doesn't appear to be offer ability to disable vlan acceleration.
However, if any software devices on top of the card do not support it for some reason,
then the issue would be seen as well.
-vlad
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-16 18:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-16 16:43 tg3 issue with tcp checksums and vlan packets Vlad Yasevich
2014-09-16 16:54 ` Michael Chan
2014-09-16 18:45 ` Vlad Yasevich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox