From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Fastabend Subject: Re: [net-next PATCH] net: sched: cls_u32: rcu can not be last node Date: Wed, 17 Sep 2014 10:31:40 -0700 Message-ID: <5419C57C.4020907@gmail.com> References: <20140917053434.2833.66129.stgit@nitbit.x32> <541921FD.1090203@hartkopp.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Oliver Hartkopp , David Miller , Eric Dumazet , Linux Kernel Network Developers , Jamal Hadi Salim To: Cong Wang Return-path: Received: from mail-oa0-f41.google.com ([209.85.219.41]:62168 "EHLO mail-oa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755801AbaIQRb7 (ORCPT ); Wed, 17 Sep 2014 13:31:59 -0400 Received: by mail-oa0-f41.google.com with SMTP id o6so1508471oag.14 for ; Wed, 17 Sep 2014 10:31:59 -0700 (PDT) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On 09/17/2014 09:40 AM, Cong Wang wrote: > On Tue, Sep 16, 2014 at 10:54 PM, Oliver Hartkopp > wrote: >> Please add an appropriate comment to the *code* to prevent this knowledge to >> disappear. No one will search/find this in git commit messages next time. >> > > +1 > > Even though I dig git log, I agree adding a one-line comment is better. > Sure I'll add a comment at the end of the structure. Thanks. -- John Fastabend Intel Corporation