From: David L Stevens <david.stevens@oracle.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCHv5 net-next 3/3] sunvnet: generate ICMP PTMUD messages for smaller port MTUs
Date: Wed, 17 Sep 2014 18:03:51 -0400 [thread overview]
Message-ID: <541A0547.3000403@oracle.com> (raw)
In-Reply-To: <5419F97C.1080105@cogentembedded.com>
On 09/17/2014 05:13 PM, Sergei Shtylyov wrote:
>> + }
>> +#if IS_ENABLED(CONFIG_IPV6)
>
> This #if could be avoided by extending the *if* statement below, no?
>
>> + else if (skb->protocol == htons(ETH_P_IPV6))
>> + icmpv6_send(skb, ICMPV6_PKT_TOOBIG, 0, localmtu);
>> +#endif
>> goto out_dropped;
>> + }
I'm not sure I understand your point, but the #if must be there to
avoid a reference to icmpv6_send() which will not be defined if
CONFIG_IPV6=n.
+-DLS
next prev parent reply other threads:[~2014-09-17 22:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 20:49 [PATCHv5 net-next 3/3] sunvnet: generate ICMP PTMUD messages for smaller port MTUs David L Stevens
2014-09-17 21:13 ` Sergei Shtylyov
2014-09-17 22:03 ` David L Stevens [this message]
2014-09-17 22:43 ` Sowmini Varadhan
2014-09-17 23:41 ` David L Stevens
2014-09-18 19:23 ` Sowmini Varadhan
2014-09-18 20:09 ` David L Stevens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541A0547.3000403@oracle.com \
--to=david.stevens@oracle.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).