* [PATCH net-next 1/2] bonding: slight optimization for bond_xmit_roundrobin()
@ 2014-09-19 13:04 Ding Tianhong
2014-09-22 19:21 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Ding Tianhong @ 2014-09-19 13:04 UTC (permalink / raw)
To: Nikolay Aleksandrov, Andy Gospodarek, Jay Vosburgh,
Veaceslav Falico, David S. Miller, Netdev
When the slave is the curr_active_slave, no need to check
whether the slave is active or not, it is always active.
Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
---
drivers/net/bonding/bond_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index b43b2df..0324603 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -3624,7 +3624,7 @@ static int bond_xmit_roundrobin(struct sk_buff *skb, struct net_device *bond_dev
*/
if (iph->protocol == IPPROTO_IGMP && skb->protocol == htons(ETH_P_IP)) {
slave = rcu_dereference(bond->curr_active_slave);
- if (slave && bond_slave_can_tx(slave))
+ if (slave)
bond_dev_queue_xmit(bond, skb, slave->dev);
else
bond_xmit_slave_id(bond, skb, 0);
--
1.7.12
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next 1/2] bonding: slight optimization for bond_xmit_roundrobin()
2014-09-19 13:04 [PATCH net-next 1/2] bonding: slight optimization for bond_xmit_roundrobin() Ding Tianhong
@ 2014-09-22 19:21 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-09-22 19:21 UTC (permalink / raw)
To: dingtianhong; +Cc: nikolay, andy, fubar, vfalico, netdev
From: Ding Tianhong <dingtianhong@huawei.com>
Date: Fri, 19 Sep 2014 21:04:57 +0800
> When the slave is the curr_active_slave, no need to check
> whether the slave is active or not, it is always active.
>
> Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-22 19:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-19 13:04 [PATCH net-next 1/2] bonding: slight optimization for bond_xmit_roundrobin() Ding Tianhong
2014-09-22 19:21 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).