From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Duyck Subject: Re: [net-next PATCH 00/29] Add support for the Intel FM10000 Ethernet Switch Host Interface Date: Fri, 19 Sep 2014 16:52:32 -0700 Message-ID: <541CC1C0.9090204@gmail.com> References: <20140918223242.10373.27403.stgit@ahduyck-bv4.jf.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Alexander Duyck , nhorman@redhat.com, netdev@vger.kernel.org, john.fastabend@gmail.com, matthew.vick@intel.com, jeffrey.t.kirsher@intel.com, sassmann@redhat.com To: davem@davemloft.net Return-path: Received: from mail-pd0-f180.google.com ([209.85.192.180]:39234 "EHLO mail-pd0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757591AbaISXwc (ORCPT ); Fri, 19 Sep 2014 19:52:32 -0400 Received: by mail-pd0-f180.google.com with SMTP id r10so849830pdi.39 for ; Fri, 19 Sep 2014 16:52:32 -0700 (PDT) In-Reply-To: <20140918223242.10373.27403.stgit@ahduyck-bv4.jf.intel.com> Sender: netdev-owner@vger.kernel.org List-ID: Dave, I was wondering what changes you wanted for these patches? The only feedback that I have gotten so far was on the last 2 patches, and a one liner about dev_consume_skb_any vs dev_kfree_skb_any. Is there something I missed, or do I need to resubmit the entire set with some other sort of fix? I was hoping you could just pull the first 27, and then I could resubmit the last 2 with an attempt at addressing formatting/comment fixes based on Richard's comments as well as a small patch for the dev_consume_skb_any change needed in the transmit cleanup. Thanks, Alex On 09/18/2014 03:35 PM, Alexander Duyck wrote: > This patch series adds support for the FM10000 Ethernet switch host > interface. The Intel FM10000 Ethernet Switch is a 48-port Ethernet switch > supporting both Ethernet ports and PCI Express host interfaces. The fm10k > driver provides support for the host interface portion of the switch, both > PF and VF. > > As the host interfaces are directly connected to the switch this results in > some significant differences versus a standard network driver. For example > there is no PHY or MII on the device. Since packets are delivered directly > from the switch to the host interface these are unnecessary. Otherwise most > of the functionality is very similar to our other network drivers such as > ixgbe or igb. For example we support all the standard network offloads, > jumbo frames, SR-IOV (64 VFS), PTP, and some VXLAN and NVGRE offloads. > > --- > > Alexander Duyck (29): > fm10k: Add skeletal frame for Intel(R) FM10000 Ethernet Switch Host Interface Driver > fm10k: Add register defines and basic structures > fm10k: Add support for TLV message parsing and generation > fm10k: Add support for basic interaction with hardware > fm10k: Add support for mailbox > fm10k: Implement PF <-> SM mailbox operations > fm10k: Add support for PF > fm10k: Add support for configuring PF interface > fm10k: Add netdev > fm10k: Add support for L2 filtering > fm10k: Add support for ndo_open/stop > fm10k: Add interrupt support > fm10k: add support for Tx/Rx rings > fm10k: Add service task to handle delayed events > fm10k: Add Tx/Rx hardware ring bring-up/tear-down > fm10k: Add transmit and receive fastpath and interrupt handlers > fm10k: Add ethtool support > fm10k: Add support for PCI power management and error handling > fm10k: Add support for multiple queues > fm10k: Add support for netdev offloads > fm10k: Add support for MACVLAN acceleration > fm10k: Add support for PF <-> VF mailbox > fm10k: Add support for VF > fm10k: Add support for SR-IOV to PF core files > fm10k: Add support for SR-IOV to driver > fm10k: Add support for IEEE DCBx > fm10k: Add support for debugfs > fm10k: Add support for ptp to hw specific files > fm10k: Add support for PTP > > > drivers/net/ethernet/intel/Kconfig | 19 > drivers/net/ethernet/intel/Makefile | 1 > drivers/net/ethernet/intel/fm10k/Makefile | 33 > drivers/net/ethernet/intel/fm10k/fm10k.h | 532 +++++ > drivers/net/ethernet/intel/fm10k/fm10k_common.c | 534 +++++ > drivers/net/ethernet/intel/fm10k/fm10k_common.h | 65 + > drivers/net/ethernet/intel/fm10k/fm10k_dcbnl.c | 174 ++ > drivers/net/ethernet/intel/fm10k/fm10k_debugfs.c | 259 +++ > drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c | 1069 +++++++++++ > drivers/net/ethernet/intel/fm10k/fm10k_iov.c | 536 +++++ > drivers/net/ethernet/intel/fm10k/fm10k_main.c | 1978 ++++++++++++++++++++ > drivers/net/ethernet/intel/fm10k/fm10k_mbx.c | 2125 ++++++++++++++++++++++ > drivers/net/ethernet/intel/fm10k/fm10k_mbx.h | 307 +++ > drivers/net/ethernet/intel/fm10k/fm10k_netdev.c | 1424 ++++++++++++++ > drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 2166 ++++++++++++++++++++++ > drivers/net/ethernet/intel/fm10k/fm10k_pf.c | 1849 +++++++++++++++++++ > drivers/net/ethernet/intel/fm10k/fm10k_pf.h | 135 + > drivers/net/ethernet/intel/fm10k/fm10k_ptp.c | 535 +++++ > drivers/net/ethernet/intel/fm10k/fm10k_tlv.c | 863 +++++++++ > drivers/net/ethernet/intel/fm10k/fm10k_tlv.h | 186 ++ > drivers/net/ethernet/intel/fm10k/fm10k_type.h | 769 ++++++++ > drivers/net/ethernet/intel/fm10k/fm10k_vf.c | 552 ++++++ > drivers/net/ethernet/intel/fm10k/fm10k_vf.h | 78 + > 23 files changed, 16189 insertions(+) > create mode 100644 drivers/net/ethernet/intel/fm10k/Makefile > create mode 100644 drivers/net/ethernet/intel/fm10k/fm10k.h > create mode 100644 drivers/net/ethernet/intel/fm10k/fm10k_common.c > create mode 100644 drivers/net/ethernet/intel/fm10k/fm10k_common.h > create mode 100644 drivers/net/ethernet/intel/fm10k/fm10k_dcbnl.c > create mode 100644 drivers/net/ethernet/intel/fm10k/fm10k_debugfs.c > create mode 100644 drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c > create mode 100644 drivers/net/ethernet/intel/fm10k/fm10k_iov.c > create mode 100644 drivers/net/ethernet/intel/fm10k/fm10k_main.c > create mode 100644 drivers/net/ethernet/intel/fm10k/fm10k_mbx.c > create mode 100644 drivers/net/ethernet/intel/fm10k/fm10k_mbx.h > create mode 100644 drivers/net/ethernet/intel/fm10k/fm10k_netdev.c > create mode 100644 drivers/net/ethernet/intel/fm10k/fm10k_pci.c > create mode 100644 drivers/net/ethernet/intel/fm10k/fm10k_pf.c > create mode 100644 drivers/net/ethernet/intel/fm10k/fm10k_pf.h > create mode 100644 drivers/net/ethernet/intel/fm10k/fm10k_ptp.c > create mode 100644 drivers/net/ethernet/intel/fm10k/fm10k_tlv.c > create mode 100644 drivers/net/ethernet/intel/fm10k/fm10k_tlv.h > create mode 100644 drivers/net/ethernet/intel/fm10k/fm10k_type.h > create mode 100644 drivers/net/ethernet/intel/fm10k/fm10k_vf.c > create mode 100644 drivers/net/ethernet/intel/fm10k/fm10k_vf.h >