From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [patch net-next v2 8/9] switchdev: introduce Netlink API Date: Fri, 19 Sep 2014 22:36:02 -0700 Message-ID: <541D1242.8080403@gmail.com> References: <1411134590-4586-1-git-send-email-jiri@resnulli.us> <1411134590-4586-9-git-send-email-jiri@resnulli.us> <541C4AFC.8060500@mojatatu.com> <20140919154946.GH1980@nanopsycho.orion> <541C6E6D.9000109@mojatatu.com> <541CAA3C.5080105@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, davem@davemloft.net, nhorman@tuxdriver.com, andy@greyhouse.net, tgraf@suug.ch, dborkman@redhat.com, ogerlitz@mellanox.com, jesse@nicira.com, pshelar@nicira.com, azhou@nicira.com, ben@decadent.org.uk, stephen@networkplumber.org, jeffrey.t.kirsher@intel.com, vyasevic@redhat.com, xiyou.wangcong@gmail.com, edumazet@google.com, sfeldma@cumulusnetworks.com, roopa@cumulusnetworks.com, linville@tuxdriver.com, dev@openvswitch.org, jasowang@redhat.com, ebiederm@xmission.com, nicolas.dichtel@6wind.com, ryazanov.s.a@gmail.com, buytenh@wantstofly.org, aviadr@mellanox.com, nbd@openwrt.org, alexei.starovoitov@gmail.com, Neil.Jerram@metaswitch.com, ronye@mellanox.com, simon.horman@netronome.com, alexander.h.duyck@intel.com To: John Fastabend , Jamal Hadi Salim , Jiri Pirko Return-path: Received: from mail-ob0-f170.google.com ([209.85.214.170]:39720 "EHLO mail-ob0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756832AbaITFgI (ORCPT ); Sat, 20 Sep 2014 01:36:08 -0400 Received: by mail-ob0-f170.google.com with SMTP id wm4so2414038obc.1 for ; Fri, 19 Sep 2014 22:36:07 -0700 (PDT) In-Reply-To: <541CAA3C.5080105@intel.com> Sender: netdev-owner@vger.kernel.org List-ID: On 09/19/14 15:12, John Fastabend wrote: > On 09/19/2014 10:57 AM, Jamal Hadi Salim wrote: >> On 09/19/14 11:49, Jiri Pirko wrote: >>> Fri, Sep 19, 2014 at 05:25:48PM CEST, jhs@mojatatu.com wrote: >> >>>> Is this just a temporary test tool? Otherwise i dont see reason >>>> for its existence (or the API that it feeds on). >>> >>> Please read the conversation I had with Pravin and Jesse in v1 thread. >>> Long story short they like to have the api separated from ovs datapath >>> so ovs daemon can use it to directly communicate with driver. Also John >>> Fastabend requested a way to work with driver flows without using ovs -> >>> that was the original reason I created switchdev genl api. >>> >>> Regarding the "sw" tool, yes it is for testing purposes now. ovs daemon >>> will use directly switchdev genl api. >>> >>> I hope I cleared this out. >>> >> >> It is - thanks Jiri. >> >> cheers, >> jamal > > Hi Jiri, > > I was considering a slightly different approach where the > device would report via netlink the fields/actions it > supported rather than creating pre-defined enums for every > possible key. > > I already need to have an API to report fields/matches > that are being supported why not have the device report > the headers as header fields (len, offset) and the > associated parse graph the hardware uses? Vendors should > have this already to describe/design their real hardware. Humm would not that slightly go against coming with a netlink API that is generic? Surely we could pay close attention when reviewing what is being added and spot when a common API needs to be introduced... This might become very similar to the private ioctl(), private wireless extensions, nl80211 testmode and well it's not extremely pretty. > > As always its better to have code and when I get some > time I'll try to write it up. Maybe its just a separate > classifier although I don't actually want two hardware > flow APIs. > > I see you dropped the RFC tag are you proposing we include > this now? > > .John >